Re: WW2 fighters fix

[Paul Vriens]

Alexandre Hardy wrote:
> WW2 Fighters fails to display any in game graphics when in OpenGL
> mode apparantly as a result of specifying both NORMAL and FULLSCREEN
> flags to Direct Draw. The patch attached prints a warning instead
> of failing to apply the settings. The patch has been tested on wine-1.1.24
> and earlier versions (1.1.21, 1.1.22).
>
> Alexandre Hardy
>
> ------------------------------------------------------------------------

Hi,

The subject of the patch should be a but more describing what it 
actually does (and include the dll/module it's touching).

Another thing is that these kind of changes need tests. You can extend 
the current tests quite easily.

I don't know anything about these modes (or if the combinations I show 
below actually make sense) but 2 quick tests on Windows 2003:

DDSCL_NORMAL | DDSCL_EXCLUSIVE : DDERR_INVALIDPARAMS
DDSCL_NORMAL | DDSCL_FULLSCREEN : DD_OK

-- 
Cheers,

Paul.

WW2 fighters fix

[Stefan Dösinger]

Am Tuesday 21 July 2009 11:58:10 schrieb Paul Vriens:
> DDSCL_NORMAL | DDSCL_FULLSCREEN : DD_OK
> If this happens on XP too(I don't know how good Windows Server 2003 is as a 
> reference for directx), I recommend to call CreateSurface to attempt to 
> create a double buffered primary surface. If this succeeds, ddraw most likely 
> switched to FULLSCREEN | EXCLUSIVE mode, if it doesn't, ddraw uses NORMAL 
> mode.