Re: [1/2] windowscodecs/tests: Add some tests for loading truncated GIF images.
13 Jul
2015
13 Jul
'15
4:59 p.m.
Series looks good to me, but I'm not sure what you're trying to pull by putting an obviously correct fix in a patch labeled "tests".
13 Jul
13 Jul
5:10 p.m.
New subject: [1/2] windowscodecs/tests: Add some tests for loading truncated GIF images.
Vincent Povirk <madewokherd(a)gmail.com> wrote:
Series looks good to me, but I'm not sure what you're trying to pull by putting an obviously correct fix in a patch labeled "tests".
You mean a test for stream being not NULL in GifDecoder_Release()? Without that part the tests crash, but since the only reason that it started to crash was the added tests, it was not a compelling reason to me to make it a separate patch. -- Dmitry.
3809
Age (days ago)
3809
Last active (days ago)
1 comments
2 participants
participants (2)
-
Dmitry Timoshkov -
Vincent Povirk