Re: msi/tests: Make tests pass for Windows Installer 3.0 [2/3]
On Sun, Jan 18, 2009 at 3:38 PM, Ge van Geldorp <ge(a)gse.nl> wrote:
I see different estimated size values for Windows Installer 2.x and 3.0 compared to 3.1 and later.
Please don't remove the check. It is set, and that's what we're testing. If the value is different on different platforms, then do like we do for other tests and add them to the check. -- James Hawkins
Hi James,
From: James Hawkins [mailto:truiken(a)gmail.com]
On Sun, Jan 18, 2009 at 3:38 PM, Ge van Geldorp <ge(a)gse.nl> wrote:
I see different estimated size values for Windows Installer 2.x and 3.0 compared to 3.1 and later.
Please don't remove the check. It is set, and that's what we're testing. If the value is different on different platforms, then do like we do for other tests and add them to the check.
Would it be ok then to check just for the existence of the value, not the value itself? If you look at http://test.winehq.org/data/1608cb99b5beb50e1b3f680c832be47944270730/xp_fg-w inxp-sp1/msi:install.html and http://test.winehq.org/data/1608cb99b5beb50e1b3f680c832be47944270730/xp_gvg- wxpprosp2/msi:install.html you'll note that e.g. the test at install.c:2500 can return at least 3 different values, so I really don't think it makes sense to check the value itself. I do see your point about checking for the existence. Ge.
On Mon, Jan 19, 2009 at 3:22 AM, Ge van Geldorp <ge(a)gse.nl> wrote:
Hi James,
From: James Hawkins [mailto:truiken(a)gmail.com]
On Sun, Jan 18, 2009 at 3:38 PM, Ge van Geldorp <ge(a)gse.nl> wrote:
I see different estimated size values for Windows Installer 2.x and 3.0 compared to 3.1 and later.
Please don't remove the check. It is set, and that's what we're testing. If the value is different on different platforms, then do like we do for other tests and add them to the check.
Would it be ok then to check just for the existence of the value, not the value itself? If you look at http://test.winehq.org/data/1608cb99b5beb50e1b3f680c832be47944270730/xp_fg-w inxp-sp1/msi:install.html and http://test.winehq.org/data/1608cb99b5beb50e1b3f680c832be47944270730/xp_gvg- wxpprosp2/msi:install.html you'll note that e.g. the test at install.c:2500 can return at least 3 different values, so I really don't think it makes sense to check the value itself. I do see your point about checking for the existence.
Ge.
Just do as we do in other tests: ok(GetLastError == Error1 /* Win9X */ || Error2 /* Win2K */ || Error3 /* WinXP */... -- -Austin
From: Austin English [mailto:austinenglish(a)gmail.com]
Just do as we do in other tests: ok(GetLastError == Error1 /* Win9X */ || Error2 /* Win2K */ || Error3 /* WinXP */...
Not possible like that in this case since the error checking is done by a helper function which takes the expected value as a parameter. Since the conscensus seems to be that we do need to check the values, I'll throw in a couple of new helper functions. Gé.
participants (3)
-
Austin English -
Ge van Geldorp -
James Hawkins