Re: [PATCH v2] d3dx9: Reduce rounding error in D3DXQuaternionToAxisAngle

[Henri Verbeet]

On 9 November 2017 at 20:04, Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> v2: Change 2.0f to simply 2.0 to make it clear that truncation is done
> after multiplication.
> Mostly for what it's worth, note that that makes no difference for a
> multiplication by two. The exponent is incremented, the significand
> stays the same.

[PATCH v2] d3dx9: Reduce rounding error in D3DXQuaternionToAxisAngle

[Alex Henrie]

2017-11-09 17:07 GMT-07:00 Henri Verbeet <hverbeet(a)gmail.com>:
> On 9 November 2017 at 20:04, Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> > v2: Change 2.0f to simply 2.0 to make it clear that truncation is done
> > after multiplication.
> > Mostly for what it's worth, note that that makes no difference for a
> > multiplication by two. The exponent is incremented, the significand
> > stays the same.

You're right, and the v2 was perhaps overkill. Thanks for the feedback.

-Alex