Re: [D3D8 PATCH] d3d8 shaders update - VS2

[Tony Lambregts]

Raphaël Junqueira wrote:

[snip]
> object->declLength = i + 1;
> -    object->function = pFunction;
>     if (NULL != pFunction) {
>       for (i = 0; 0xFFFFFFFF != pFunction[i]; ++i) ;
>       object->functionLength = i + 1;
>     } else {
> -      object->functionLength = 1; /* no Function defined use fixed function vertex processing */
> +      object->functionLength = 1; // no Function defined use fixed function vertex processing

<nitpick> C++ style comments are strongly discouraged </nitpick>

-- 

Tony Lambregts

[D3D8 PATCH] d3d8 shaders update - VS2

[Raphaël Junqueira]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 18 December 2002 02:08, Tony Lambregts wrote:
> Raphaël Junqueira wrote:
>
> [snip]
> > object->declLength = i + 1;
> > -    object->function = pFunction;
> >     if (NULL != pFunction) {
> >       for (i = 0; 0xFFFFFFFF != pFunction[i]; ++i) ;
> >       object->functionLength = i + 1;
> >     } else {
> > -      object->functionLength = 1; /* no Function defined use fixed
> > function vertex processing */ +      object->functionLength = 1; // no
> > Function defined use fixed function vertex processing
>
> <nitpick> C++ style comments are strongly discouraged </nitpick>

Hi,

yes, i know but this comment is INTO a block comment ;)
and C comments will break the block comment

regards, Raphael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+ACUcp7NA3AmQTU4RAtIVAKCBGBj62TB1Fu2URiFGNUBPlrKqrwCfbVqR
B5J4LRyILcOX5k0bgs8xf08=
=3ITV
-----END PGP SIGNATURE-----

[D3D8 PATCH] d3d8 shaders update - VS2

[Fabian Cenedese]

> > > -      object->functionLength = 1; /* no Function defined use fixed
> > > function vertex processing */ +      object->functionLength = 1; // no
> > > Function defined use fixed function vertex processing
> >
> > <nitpick> C++ style comments are strongly discouraged </nitpick>
>
> yes, i know but this comment is INTO a block comment ;)
> and C comments will break the block comment

What I usually do in such a case is change the existing tags like that:

code /* comment */

becomes (note the spaces in the tags).

/* block comment
code / * comment * /
*/

Like that you still see where the comment was but it doesn't end the block
anymore. Of course if the block comment gets removed you have to change
the tags back.

bye  Fabi

[D3D8 PATCH] d3d8 shaders update - VS2

[Francois Gouget]

On Wed, 18 Dec 2002, Raphaël Junqueira wrote:
> On Wednesday 18 December 2002 02:08, Tony Lambregts wrote:

[...]
> > <nitpick> C++ style comments are strongly discouraged </nitpick>
>
> Hi,
>
> yes, i know but this comment is INTO a block comment ;)
> and C comments will break the block comment

The susual trick in such cases is to leave a space between the '*' and
the '/':
> object->functionLength = 1; /* no Function defined use fixed function vertex processing * /

-- 
Francois Gouget         fgouget(a)free.fr        http://fgouget.free.fr/
In theory, theory and practice are the same, but in practice they're different.

[D3D8 PATCH] d3d8 shaders update - VS2

[Raphaël Junqueira]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 18 December 2002 09:21, Francois Gouget wrote:
> On Wed, 18 Dec 2002, Raphaël Junqueira wrote:
> > On Wednesday 18 December 2002 02:08, Tony Lambregts wrote:
>
> [...]
> > > <nitpick> C++ style comments are strongly discouraged </nitpick>
> >
> > Hi,
> >
> > yes, i know but this comment is INTO a block comment ;)
> > and C comments will break the block comment
>
> The susual trick in such cases is to leave a space between the '*' and
>
> the '/':
> > object->functionLength = 1; /* no Function defined use fixed function
> > vertex processing * /

ok, why not

anyway this comment will be removed soon, 
it's here only for remembering me for HAL support and code cleaning ;)

regards, Raphael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+ANmXp7NA3AmQTU4RAt4VAJ9zMCPu5jpmnU/igd3a2cll0rqY0wCeNO6M
cAUJAoj9V1IsDBY2uWfXlgw=
=XLbE
-----END PGP SIGNATURE-----