Re: aclui: Remove some unneeded header inclusions. (IWYU)

[Alexandre Julliard]

Amine Khaldi <amine.khaldi(a)reactos.org> writes:
> @@ -18,15 +18,7 @@
>   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
>   */
>
> -#include "config.h"
> -
> -#include <stdarg.h>
> -
>  #include "initguid.h"
> -#include "windef.h"
> -#include "winbase.h"
> -#include "winuser.h"
> -#include "winnt.h"
>  #include "aclui.h"

That's not useful. The headers will be included anyway.

-- 
Alexandre Julliard
julliard(a)winehq.org

aclui: Remove some unneeded header inclusions. (IWYU)

[Amine Khaldi]

On 06/09/2013 16:28, Alexandre Julliard wrote:
> Amine Khaldi <amine.khaldi(a)reactos.org> writes:
> > @@ -18,15 +18,7 @@
> >   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
> >   */
> >
> > -#include "config.h"
> > -
> > -#include <stdarg.h>
> > -
> >  #include "initguid.h"
> > -#include "windef.h"
> > -#include "winbase.h"
> > -#include "winuser.h"
> > -#include "winnt.h"
> >  #include "aclui.h"
> > That's not useful. The headers will be included anyway.

Indeed. Are there some benefits of including them more than once here ?

Regards,
Amine.

aclui: Remove some unneeded header inclusions. (IWYU)

[Alexandre Julliard]

Amine Khaldi <amine.khaldi(a)reactos.org> writes:
> On 06/09/2013 16:28, Alexandre Julliard wrote:
> > Amine Khaldi <amine.khaldi(a)reactos.org> writes:
> > > @@ -18,15 +18,7 @@
> > >   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
> > >   */
> > >
> > > -#include "config.h"
> > > -
> > > -#include <stdarg.h>
> > > -
> > >  #include "initguid.h"
> > > -#include "windef.h"
> > > -#include "winbase.h"
> > > -#include "winuser.h"
> > > -#include "winnt.h"
> > >  #include "aclui.h"
> > > That's not useful. The headers will be included anyway.
>
> Indeed. Are there some benefits of including them more than once here ?

No, but it's harmless, so there's no reason to change it.

-- 
Alexandre Julliard
julliard(a)winehq.org