Re: [1/2] (resend with array adaptation) user32/tests/class.c: Test extra value of standard dialog and edit classes

[Paul Vriens]

On 10/21/2009 11:46 AM, Julius Schwartzenberg wrote:
> This is the test for bug #2181. The patch will follow. Currently the
> test checks the value of just two classes, it may be useful to extend
> this in the future. The test passes on Windows for Workgroups 3.11,
> Windows 98, Windows XP 32-bit and with the broken call on Windows XP
> 64-bit.

Hi Julius,

Tests that fail on Wine should be marked todo_wine:

class.c:866: Test failed: expected 6, got 4

You can remove the todo_wine again in the patch that fixes Wine.

Another approach is maybe send the fix as patch1 and the test as patch2?

-- 
Cheers,

Paul.

[1/2] (resend with array adaptation) user32/tests/class.c: Test extra value of standard dialog and edit classes

[Juan Lang]

> Another approach is maybe send the fix as patch1 and the test as patch2?

Personally, I don't like this approach.  It can be useful when the fix
corrects a crash, but otherwise, it may be unclear that the fix is
correct until the tests are accepted.  If the test is acceptable but
the fix is not, then at least the test gets committed.
--Juan

[1/2] (resend with array adaptation) user32/tests/class.c: Test extra value of standard dialog and edit classes

[Paul Vriens]

On 10/21/2009 05:04 PM, Juan Lang wrote:
> > Another approach is maybe send the fix as patch1 and the test as patch2?
>
> Personally, I don't like this approach.  It can be useful when the fix
> corrects a crash, but otherwise, it may be unclear that the fix is
> correct until the tests are accepted.  If the test is acceptable but
> the fix is not, then at least the test gets committed.
> --Juan

Agreed, so we need a todo_wine on one of these tests.

-- 
Cheers,

Paul.