Re: implement fixme in CreateAcceleratorTable

[Dmitry Timoshkov]

"Pabs" <pabs3(a)bonedaddy.net> wrote:
> ChangeLog
>
> Added some checks to CreateAcceleratorTableA/W (removes fixmes)

IMO it's better to use

if (!MapVirtualKeyW(lpaccel[i].key, 0))
{
    WARN("Invalid VK\n");
    SetLastError(ERROR_INVALID_PARAMETER);
    return NULL;
}

for a check whether VK is a valid one.

-- 
Dmitry.

implement fixme in CreateAcceleratorTable

[Pabs]

On Sat, 2004-02-28 at 09:46, Dmitry Timoshkov wrote:
> "Pabs" <pabs3(a)bonedaddy.net> wrote:
> > ChangeLog
> >
> > Added some checks to CreateAcceleratorTableA/W (removes fixmes)
>
> IMO it's better to use
>
> if (!MapVirtualKeyW(lpaccel[i].key, 0))
> {
>     WARN("Invalid VK\n");
>     SetLastError(ERROR_INVALID_PARAMETER);
>     return NULL;
> }
>
> for a check whether VK is a valid one.

This being the first time I have looked at the wine source code I didn't
think of that. I agree, this is a better idea. It would be interesting
to know how windows does it though.

-- 
Bye,
Pabs