Re: [PATCH 2/5] wined3d: refactoring - add a real gl vendor detection

[Henri Verbeet]

On 1 March 2010 19:27, PAUL ANDREW PANON <ppanon(a)shaw.ca> wrote:
> +    gl_vendor = wined3d_guess_gl_vendor(gl_info, gl_string, gl_renderer);
>      card_vendor = wined3d_guess_card_vendor(gl_string, gl_renderer);
> -    TRACE_(d3d_caps)("found GL_VENDOR (%s)->(0x%04x)\n", debugstr_a(gl_string), card_vendor);
> +    TRACE_(d3d_caps)("found GL_VENDOR (%s)->(0x%04x/0x%04x)\n", debugstr_a(gl_string), gl_vendor, card_vendor);

Sorry for not noticing this earlier, but you can't do that there. The
Apple detection uses the list of supported extensions, but that list
isn't initialized until further below. If there's no code that depends
on the gl_vendor before, you can probably just move it down a bit to
the same place that calls wined3d_guess_card(), possibly moving
wined3d_guess_card_vendor() as well.