Re: gdi32/tests: Remove two variables which are not really used from test_clipping.

[Nikolay Sivov]

On 5/3/2010 03:48, Gerald Pfeifer wrote:
> ---
>   dlls/gdi32/tests/bitmap.c |    4 ----
>   1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/dlls/gdi32/tests/bitmap.c b/dlls/gdi32/tests/bitmap.c
> index 882d548..b570a8a 100644
> --- a/dlls/gdi32/tests/bitmap.c
> +++ b/dlls/gdi32/tests/bitmap.c
> @@ -2810,9 +2810,7 @@ static void test_GdiAlphaBlend(void)
>   static void test_clipping(void)
>   {
>       HBITMAP bmpDst;
> -    HBITMAP oldDst;
>       HBITMAP bmpSrc;
> -    HBITMAP oldSrc;
>       HRGN hRgn;
>       LPVOID bits;
>       BOOL result;
> @@ -2830,11 +2828,9 @@ static void test_clipping(void)
>
> bmpDst = CreateDIBSection( hdcDst,&bmpinfo, DIB_RGB_COLORS,&bits, NULL, 0 );
>       ok(bmpDst != NULL, "Couldn't create destination bitmap\n");
> -    oldDst = SelectObject( hdcDst, bmpDst );
>
> bmpSrc = CreateDIBSection( hdcSrc,&bmpinfo, DIB_RGB_COLORS,&bits, NULL, 0 );
>       ok(bmpSrc != NULL, "Couldn't create source bitmap\n");
> -    oldSrc = SelectObject( hdcSrc, bmpSrc );
>
> result = BitBlt( hdcDst, 0, 0, 100, 100, hdcSrc, 100, 100, SRCCOPY );
>       ok(result, "BitBlt failed\n");

Bitmap are useless after this change.

gdi32/tests: Remove two variables which are not really used from test_clipping.

[Gerald Pfeifer]

On Mon, 3 May 2010, Nikolay Sivov wrote:
> Bitmap are useless after this change.

Darn, I may have sent the wrong version of the patch.  Let me look
into this tonight or tomorrow. 

You have sharp eyes, Nikolay! :-)

Gerald

gdi32/tests: Remove two variables which are not really used from test_clipping.

[Gerald Pfeifer]

On Mon, 3 May 2010, Nikolay Sivov wrote:
> Bitmap are useless after this change.

I'll submit a patch which has this fixed.  Interestingly, at least on
my FreeBSD-based tester, test results did _not_ regress either way.

Gerald