Re: [PATCH] winsock-test.diff

[Alexandre Julliard]

Martin Wilck <Martin.Wilck(a)Fujitsu-Siemens.com> writes:
> Rationale:
> - Make it easier to add new unit tests.
> - Conform better to the usual wine unit testing scheme 
>   (instead of running different tests from the same file,
>   run separate files testing different functionality)

That's not really the usual scheme. It may look that way because we
have few tests at the moment, but we can't put each test in a separate
file, or we will end up with thousands of them. The right approach is
to follow more or less the layout of the source files, that is if two
APIs are implemented in the same source file they should be tested in
the same test file; so I think the current winsock tests are OK as
they are. And in any case #including .c files is strongly discouraged.

-- 
Alexandre Julliard
julliard(a)winehq.com

[PATCH] winsock-test.diff

[Martin Wilck]

Am Mit, 2002-09-04 um 20.57 schrieb Alexandre Julliard:
> I think the current winsock tests are OK as
> they are. And in any case #including .c files is strongly discouraged.

Well, OK, as you like - just forget about it.

Martin

PS I usually don't #include .c either, but for the standalone unit tests
I thought it'd be ok and the simplest method to avoid code duplication.

-- 
Martin Wilck                Phone: [phone]
Fujitsu Siemens Computers   Fax:   [phone]
Heinz-Nixdorf-Ring 1	    mailto:Martin.Wilck(a)Fujitsu-Siemens.com
D-33106 Paderborn           http://www.fujitsu-siemens.com/primergy