[PATCH] atl100/tests: Fix a memory leak (Valgrind).
Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> --- dlls/atl100/tests/atl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/atl100/tests/atl.c b/dlls/atl100/tests/atl.c index bdd3c57eb0..d23c53c104 100644 --- a/dlls/atl100/tests/atl.c +++ b/dlls/atl100/tests/atl.c @@ -964,6 +964,8 @@ static void test_AtlAxCreateControl(void) ok(hr == S_OK, "got 0x%08x\n", hr); ok(container != NULL, "returned %p!\n", container); ok(control != NULL, "returned %p\n", control); + IUnknown_Release(container); + IUnknown_Release(control); DestroyWindow(hwnd); container = NULL; -- 2.20.1
Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> --- dlls/comctl32/tests/edit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/comctl32/tests/edit.c b/dlls/comctl32/tests/edit.c index bc44d0c240..db4051a947 100644 --- a/dlls/comctl32/tests/edit.c +++ b/dlls/comctl32/tests/edit.c @@ -2927,6 +2927,8 @@ static void test_paste(void) len = SendMessageA(hEdit, WM_GETTEXTLENGTH, 0, 0); ok(strlen(str) == len, "got %d\n", len); + GlobalFree(hmem); + /* Prepare clipboard data with multiline text */ hmem = GlobalAlloc(GMEM_MOVEABLE, 255); ok(hmem != NULL, "got %p (expected != NULL)\n", hmem); @@ -2957,6 +2959,7 @@ static void test_paste(void) ok(strlen(str2) == len, "got %d\n", len); /* Cleanup */ + GlobalFree(hmem); DestroyWindow(hEdit); DestroyWindow(hMultilineEdit); } -- 2.20.1
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=46378 Your paranoid android. === wxppro (32 bit report) === comctl32: edit.c:2945: Test failed: expected 00C60044, got 00000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === w2003std (32 bit report) === comctl32: edit.c:2945: Test failed: expected 00F00044, got 00000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === wvistau64 (32 bit report) === comctl32: edit.c:2945: Test failed: expected 00EA0004, got 00000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === wvistau64_zh_CN (32 bit report) === comctl32: edit.c:2945: Test failed: expected 00830004, got 00000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === wvistau64_fr (32 bit report) === comctl32: edit.c:2945: Test failed: expected 02790004, got 00000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === wvistau64_he (32 bit report) === comctl32: edit.c:2945: Test failed: expected 00650004, got 00000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === w2008s64 (32 bit report) === comctl32: edit.c:2945: Test failed: expected 00CB0004, got 00000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === w7u (32 bit report) === comctl32: edit.c:2945: Test failed: expected 0072004C, got 00000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === w7pro64 (32 bit report) === comctl32: edit.c:2945: Test failed: expected 0205004C, got 00000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === w8 (32 bit report) === comctl32: edit.c:2945: Test failed: expected 017D004C, got 00000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === w8adm (32 bit report) === comctl32: edit.c:2945: Test failed: expected 0195004C, got 00000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === w864 (32 bit report) === comctl32: edit.c:2945: Test failed: expected 006E004C, got 00000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === w1064 (32 bit report) === comctl32: edit.c:2945: Test failed: expected 0069004C, got 00000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === wvistau64 (64 bit report) === comctl32: edit.c:2945: Test failed: expected 0000000002790008, got 0000000000000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === w2008s64 (64 bit report) === comctl32: edit.c:2945: Test failed: expected 0000000000C40008, got 0000000000000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === w7pro64 (64 bit report) === comctl32: edit.c:2945: Test failed: expected 0000000002560098, got 0000000000000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === w864 (64 bit report) === comctl32: edit.c:2945: Test failed: expected 00000000022D0098, got 0000000000000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === w1064 (64 bit report) === comctl32: edit.c:2945: Test failed: expected 0000000000690098, got 0000000000000000 edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === debian9 (32 bit report) === comctl32: edit.c:2945: Test failed: expected 0x130b3a, got (nil) edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === debian9 (32 bit French report) === comctl32: edit.c:2945: Test failed: expected 0x13161a, got (nil) edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === debian9 (32 bit Japanese:Japan report) === comctl32: edit.c:2945: Test failed: expected 0x1309e2, got (nil) edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === debian9 (32 bit Chinese:China report) === comctl32: edit.c:2945: Test failed: expected 0x12bff2, got (nil) edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === debian9 (32 bit WoW report) === comctl32: edit.c:2945: Test failed: expected 0x130baa, got (nil) edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0 === debian9 (64 bit WoW report) === comctl32: edit.c:2945: Test failed: expected 0x45f22, got (nil) edit.c:2953: Test failed: got 0 edit.c:2959: Test failed: got 0
participants (2)
-
Gijs Vermeulen -
Marvin