Re: SMATCH: add missing LeaveCriticalSection

[Dan Kegel]

Michael Stefaniuc wrote:
> on some error path the critical section wasn't released.
> Found with smatch's help.

I'm impressed.  Didn't know smatch could detect this kind of
thing in Wine code.

For those who haven't heard of smatch, see http://smatch.sf.net
- Dan

-- 
Dan Kegel
http://www.kegel.com
http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

SMATCH: add missing LeaveCriticalSection

[Michael Stefaniuc]

On Sun, Feb 09, 2003 at 04:27:22PM -0800, Dan Kegel wrote:
> Michael Stefaniuc wrote:
> > on some error path the critical section wasn't released.
> > Found with smatch's help.
>
> I'm impressed.  Didn't know smatch could detect this kind of
> thing in Wine code.
> I had to adapt a script from smatch to do this, but to be honest,
> searching for missing LeaveCriticalSection's is a trivial task for
> smatch. I'll do some more wine specific scripts, easier ones first to
> get used to smatch.
> For those who haven't heard of smatch, see http://smatch.sf.net

bye
	michael
-- 
Michael Stefaniuc               Tel.: [phone]
System Administration           Fax.: [phone]
Red Hat GmbH                    Email: mstefani(a)redhat.com
Hauptstaetterstr. 58            http://www.redhat.de/
D-70178 Stuttgart