Re: msvcrt[2/3]: add initial tests for dlls/msvcrt/data.c [try 2]
"Andrew" == Andrew Ziem <ahziem1(a)mailbolt.com> writes:
Andrew> because tests yield inconsistent results */ +#if 0 + /* address #if 0 in a patch is depreciated. If the test fails on wine, butt succeeds in windows, use todo_wine(). If there are other conditions that must be met, tell these conditions, perhaps like #define SOME_SPECIAL_TEST 0 #ifdef SOME_SPECIAL_TEST so that others can decipher what you mean. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
Uwe Bonnes wrote:
"Andrew" == Andrew Ziem <ahziem1(a)mailbolt.com> writes:
Andrew> because tests yield inconsistent results */ +#if 0 + /* address
#if 0 in a patch is depreciated. If the test fails on wine, butt succeeds in windows, use todo_wine(). If there are other conditions that must be met, tell these conditions, perhaps like
#define SOME_SPECIAL_TEST 0 #ifdef SOME_SPECIAL_TEST
so that others can decipher what you mean.
Sorry, I meant to document the conditions under which Windows 2000 yields inconsistent results. For example, in the first ok() on Windows 2000, _initterm() returned either 0 or 1. Also, one of the "#if 0" blocks documents a condition that crashes both Wine and Windows 2000. Andrew
Andrew Ziem <ahziem1(a)mailbolt.com> writes:
Sorry, I meant to document the conditions under which Windows 2000 yields inconsistent results. For example, in the first ok() on Windows 2000, _initterm() returned either 0 or 1.
Also, one of the "#if 0" blocks documents a condition that crashes both Wine and Windows 2000.
As a rule, passing garbage to an API is not an interesting thing to test, unless the API does something special with it on Windows. -- Alexandre Julliard julliard(a)winehq.org
participants (3)
-
Alexandre Julliard -
Andrew Ziem -
Uwe Bonnes