X11DRV_XRandR_Cleanup() is not used
dlls/x11drv/xrandr.c defines a X11DRV_XRandR_Cleanup() function but it is not actually used anywhere. If I remember correctly past wine-devel emails, restoring the right XRandR mode when an application exits can be tricky (especially in case of a crash). So maybe this is why the function is not called, though I'm not sure it's even related. So my question is: should this function be removed? Or should I simply send a patch calling it from x11drv_main.c:process_detach(), enclosed with the appropriate SONAME_LIBXRANDR? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Good judgment comes from experience, and experience comes from bad judgment -- Barry LePatner
Francois Gouget <fgouget(a)free.fr> writes:
So my question is: should this function be removed? Or should I simply send a patch calling it from x11drv_main.c:process_detach(), enclosed with the appropriate SONAME_LIBXRANDR?
You can remove it, it doesn't do anything useful. -- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alexandre Julliard -
Francois Gouget