Getopt - was Re: problem on the Cygwin port

[Steven Edwards]

Hi Christian,
--- Christian Costa <titan.costa(a)wanadoo.fr> wrote:
> I'm not sure but I remember I had a similar problem when I tried to 
> compile wine on cygwin.
> In my case, the get_opt_long function seemed broken and I modified
> the 
> config.h to force the use
> our own implementation of this function. This has fixed my problem.

Thanks that fixed it. I doubt Alexandre will accept this as its a
cygwin problem but here is a patch in any case.

Changelog:
Work around broken getopt implementation on Cygwin


Index: wine/include/wine/port.h
===================================================================
RCS file: /home/wine/wine/include/wine/port.h,v
retrieving revision 1.46
diff -u -r1.46 port.h
--- wine/include/wine/port.h	8 Jan 2004 05:07:06 -0000	1.46
+++ wine/include/wine/port.h	12 Feb 2004 21:23:22 -0000
@@ -199,7 +199,7 @@
 
 #ifndef NO_LIBWINE_PORT
 
-#ifndef HAVE_GETOPT_LONG
+#if !defined(HAVE_GETOPT_LONG) || defined (__CYGWIN__)
 extern char *optarg;
 extern int optind;
 extern int opterr;


__________________________________
Do you Yahoo!?
Yahoo! Finance: Get your refund fast by filing online.
http://taxes.yahoo.com/filing.html

[Dimitrie O. Paun]

On Thu, 12 Feb 2004, Steven Edwards wrote:
> -#ifndef HAVE_GETOPT_LONG
> +#if !defined(HAVE_GETOPT_LONG) || defined (__CYGWIN__)

Shouldn't we check in configure if the getopt_long is broken,
and if so, not use it?

-- 
Dimi.

[Steven Edwards]

--- "Dimitrie O. Paun" <dimi(a)intelliware.ca> wrote:
> > -#ifndef HAVE_GETOPT_LONG
> > +#if !defined(HAVE_GETOPT_LONG) || defined (__CYGWIN__)
>
> Shouldn't we check in configure if the getopt_long is broken,
> and if so, not use it?

Yes we should I just didnt have time to do the proper check and rerun
configure. I am going to try to find time to do this soon if no one
beats me to it.

Thanks
Steven

__________________________________
Do you Yahoo!?
Yahoo! Finance: Get your refund fast by filing online.
http://taxes.yahoo.com/filing.html