Re: [PATCH 2/5] gameux: Add stub of IGameStatisticsMgr implementation (try 2)

[Nikolay Sivov]

On 8/3/2010 13:58, Mariusz Pluciński wrote:
> ---
>  dlls/gameux/Makefile.in      |    1 +
>  dlls/gameux/factory.c        |    5 ++
>  dlls/gameux/gamestatistics.c |  153 
> ++++++++++++++++++++++++++++++++++++++++++
>  dlls/gameux/gameux_private.h |    1 +
>  dlls/gameux/regsvr.c         |    9 +++
>  5 files changed, 169 insertions(+), 0 deletions(-)
>  create mode 100644 dlls/gameux/gamestatistics.c
> +    TRACE("(%p, %s, 0x%x, %p, %p)\n", iface, debugstr_w(GDFBinaryPath), openType, pOpenResult, ppiStats);
> +    FIXME("stub\n");
> +    return E_NOTIMPL;
> No need for duplicated traces, add one FIXME with full parameter output 
> in it.

[PATCH 2/5] gameux: Add stub of IGameStatisticsMgr implementation (try 2)

[Mariusz Pluciński]

W dniu 03.08.2010 13:28, Nikolay Sivov pisze:
> On 8/3/2010 13:58, Mariusz Pluciński wrote:
> > ---
> > dlls/gameux/Makefile.in | 1 +
> > dlls/gameux/factory.c | 5 ++
> > dlls/gameux/gamestatistics.c | 153
> > ++++++++++++++++++++++++++++++++++++++++++
> > dlls/gameux/gameux_private.h | 1 +
> > dlls/gameux/regsvr.c | 9 +++
> > 5 files changed, 169 insertions(+), 0 deletions(-)
> > create mode 100644 dlls/gameux/gamestatistics.c
> > + TRACE("(%p, %s, 0x%x, %p, %p)\n", iface, debugstr_w(GDFBinaryPath),
> > openType, pOpenResult, ppiStats);
> > + FIXME("stub\n");
> > + return E_NOTIMPL;
> > No need for duplicated traces, add one FIXME with full parameter output
> > in it.

I hope my patches are acceptable despite of this. But in the future I'll 
avoid it, thanks.

[PATCH 2/5] gameux: Add stub of IGameStatisticsMgr implementation (try 2)

[Jerome Leclanche]

Just resend this one, it's easier that way.


J. Leclanche / Adys



2010/8/3 Mariusz Pluciński <vshader(a)gmail.com>:
> W dniu 03.08.2010 13:28, Nikolay Sivov pisze:
> > On 8/3/2010 13:58, Mariusz Pluciński wrote:
> > > ---
> > > dlls/gameux/Makefile.in | 1 +
> > > dlls/gameux/factory.c | 5 ++
> > > dlls/gameux/gamestatistics.c | 153
> > > ++++++++++++++++++++++++++++++++++++++++++
> > > dlls/gameux/gameux_private.h | 1 +
> > > dlls/gameux/regsvr.c | 9 +++
> > > 5 files changed, 169 insertions(+), 0 deletions(-)
> > > create mode 100644 dlls/gameux/gamestatistics.c
> > > + TRACE("(%p, %s, 0x%x, %p, %p)\n", iface, debugstr_w(GDFBinaryPath),
> > > openType, pOpenResult, ppiStats);
> > > + FIXME("stub\n");
> > > + return E_NOTIMPL;
> >
> > No need for duplicated traces, add one FIXME with full parameter output
> > in it.
>
> I hope my patches are acceptable despite of this. But in the future I'll
> avoid it, thanks.

[PATCH 2/5] gameux: Add stub of IGameStatisticsMgr implementation (try 2)

[Mariusz Pluciński]

W dniu 04.08.2010 20:45, Jerome Leclanche pisze:
> Just resend this one, it's easier that way.
>
> J. Leclanche / Adys
>
> 2010/8/3 Mariusz Pluciński<vshader(a)gmail.com>:
> > W dniu 03.08.2010 13:28, Nikolay Sivov pisze:
> > > On 8/3/2010 13:58, Mariusz Pluciński wrote:
> > > > ---
> > > > dlls/gameux/Makefile.in | 1 +
> > > > dlls/gameux/factory.c | 5 ++
> > > > dlls/gameux/gamestatistics.c | 153
> > > > ++++++++++++++++++++++++++++++++++++++++++
> > > > dlls/gameux/gameux_private.h | 1 +
> > > > dlls/gameux/regsvr.c | 9 +++
> > > > 5 files changed, 169 insertions(+), 0 deletions(-)
> > > > create mode 100644 dlls/gameux/gamestatistics.c
> > > > + TRACE("(%p, %s, 0x%x, %p, %p)\n", iface, debugstr_w(GDFBinaryPath),
> > > > openType, pOpenResult, ppiStats);
> > > > + FIXME("stub\n");
> > > > + return E_NOTIMPL;
> > >
> > > No need for duplicated traces, add one FIXME with full parameter output
> > > in it.
> >
> > I hope my patches are acceptable despite of this. But in the future I'll
> > avoid it, thanks.

You may be right. I'll do it, thanks.