RE: [PATCH] regsvr32: Fix some usage message issues
On Tuesday, 1 April 2014 4:34 PM, Nikolay Sivov wrote:
- regsvr32 itself is not a server or service - it doesn't unregister a module from a server, module IS a server in this context
The actual executable in XP and W7 describes itself a "registration server". But I'm happy to go with this change if you believe it is appropriate. There is also the RC define to consider: #define WINE_FILEDESCRIPTION_STR "Wine Register Server"
When used with [/u], regsvr32 also calls DllInstall in uninstall mode.\n - there's no such thing as 'DLL Uninstall', same DllInstall call is used in both cases This is true; Lauri Kenttä raised that point in this post: http://www.winehq.org/pipermail/wine-devel/2014-March/103671.html
In the following discussion, Lauri and Austin English chose to remove the additional reference to 'regsvr32' and 'also'. The preferred option was this text: [/i] Call DllInstall, passing an optional [cmdline]. When used with [/u], calls DllInstall to uninstall the DLL. Of course, your change reflects the original dialog: When used with [/u], regsvr32 also calls DllInstall in uninstall mode. Perhaps you could change it to: When used with [/u], calls DllInstall in uninstall mode. I'm not sure which option would be preferred. Free free to patch using the dialog from the linked thread.
On 4/1/2014 15:12, Hugh McMaster wrote:
On Tuesday, 1 April 2014 4:34 PM, Nikolay Sivov wrote:
- regsvr32 itself is not a server or service - it doesn't unregister a module from a server, module IS a server in this context The actual executable in XP and W7 describes itself a "registration server". But I'm happy to go with this change if you believe it is appropriate. I know it's called like that, but we don't have to be misleading too. There is also the RC define to consider: #define WINE_FILEDESCRIPTION_STR "Wine Register Server" I chose to keep that one for now, as it's invisible to user and for now I want to adjust only a message.
When used with [/u], regsvr32 also calls DllInstall in uninstall mode.\n - there's no such thing as 'DLL Uninstall', same DllInstall call is used in both cases This is true; Lauri Kenttä raised that point in this post: http://www.winehq.org/pipermail/wine-devel/2014-March/103671.html I missed that.
In the following discussion, Lauri and Austin English chose to remove the additional reference to 'regsvr32' and 'also'.
The preferred option was this text: [/i] Call DllInstall, passing an optional [cmdline]. When used with [/u], calls DllInstall to uninstall the DLL.
Of course, your change reflects the original dialog: When used with [/u], regsvr32 also calls DllInstall in uninstall mode.
Perhaps you could change it to: When used with [/u], calls DllInstall in uninstall mode.
I'm not sure which option would be preferred. Free free to patch using the dialog from the linked thread. I sent another version. The reason I bothered to send it in a first place was after I decided to update Russian po, and found that message is a bit off, for /u part especially. So instead of making only Russian message right I decided to change original.
On Tuesday, 1 April 2014 10:31 PM, Nikolay Sivov wrote:
I sent another version.
Would you consider chaning 'server' to 'module' again? - STRING_HEADER, "Wine DLL Registration Server\n\n\ + STRING_HEADER, "Wine DLL Registration Utility\n\n\ -\ [/u] Unregister a module from the server.\n\ +\ [/u] Unregister a module.\n\ -\tWhen used with [/u], regsvr32 also calls DLL Uninstall.\n\ +\tWhen used with [/u], DllInstall is called in uninstall mode.\n\
participants (2)
-
Hugh McMaster -
Nikolay Sivov