Re: dlls/winex11.drv/dib.c: initialize two warnings (RESEND)
31 Oct
2009
31 Oct
'09
9 p.m.
Gerald Pfeifer <gerald(a)pfeifer.com> writes:
I looked into this in more detail, and now remember why I couldn't do this.
From X11DRV_GetDIBits() we invoke DIB_GetBitmapInfo() with these two variables being passed by addresses which in turns forwards to DIB_GetBitmapInfoEx(). And there we have a default case of
ERR("(%d): unknown/wrong size for header\n", header->biSize ); return -1;
where indeed height and width are not initialized, so GCC 4.5 is right.
No, because the error case causes the caller function to return without using them. The idea was to reorder the code so that gcc can figure this out, as it does already in the other cases. -- Alexandre Julliard julliard(a)winehq.org
5887
Age (days ago)
5887
Last active (days ago)
0 comments
1 participants
participants (1)
-
Alexandre Julliard