[PATCH 1/3] cabinet/tests: Alter string declaration to include null terminator.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=55571

Your paranoid android.


=== debian10 (32 bit report) ===

cabinet:
fdi.c:786: Test failed: expected HelloWorld!, got Hello World!

=== debian10 (32 bit French report) ===

cabinet:
fdi.c:786: Test failed: expected HelloWorld!, got Hello World!

=== debian10 (32 bit Japanese:Japan report) ===

cabinet:
fdi.c:786: Test failed: expected HelloWorld!, got Hello World!

=== debian10 (32 bit Chinese:China report) ===

cabinet:
fdi.c:786: Test failed: expected HelloWorld!, got Hello World!

=== debian10 (32 bit WoW report) ===

cabinet:
fdi.c:786: Test failed: expected HelloWorld!, got Hello World!

=== debian10 (64 bit WoW report) ===

cabinet:
fdi.c:786: Test failed: expected HelloWorld!, got Hello World!

[Alex Henrie]

+ * Copyright (C) 2019 Isira Seneviratne

-    static const char expected[12] = "Hello World!";
+    static const char expected[12] = {
'H','e','l','l','o','W','o','r','l','d','!','\0' };

All you had to do was remove the number 12 and let the compiler
determine the size of the array automatically. And you really
shouldn't add your name at the top of the file unless you wrote a
substantial chunk of the file.

-Alex

[Isira Seneviratne]

On Mon, Aug 19, 2019, 1:42 AM Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> + * Copyright (C) 2019 Isira Seneviratne
>
> -    static const char expected[12] = "Hello World!";
> +    static const char expected[12] = {
> 'H','e','l','l','o','W','o','r','l','d','!','\0' };
>
> All you had to do was remove the number 12 and let the compiler
> determine the size of the array automatically. And you really
> shouldn't add your name at the top of the file unless you wrote a
> substantial chunk of the file.
>
> -Alex

Okay, thanks.

By the way, why would the tests fail?
>

[Chip Davis]

August 18, 2019 5:51 PM, "Isira Seneviratne" <isirasen96(a)gmail.com (mailto:%22Isira%20Seneviratne%22%20<isirasen96(a)gmail.com>)> wrote:
 On Mon, Aug 19, 2019, 1:42 AM Alex Henrie <alexhenrie24(a)gmail.com (mailto:alexhenrie24(a)gmail.com)> wrote: + * Copyright (C) 2019 Isira Seneviratne

- static const char expected[12] = "Hello World!";
+ static const char expected[12] = {
'H','e','l','l','o','W','o','r','l','d','!','' };

All you had to do was remove the number 12 and let the compiler
determine the size of the array automatically. And you really
shouldn't add your name at the top of the file unless you wrote a
substantial chunk of the file.

-Alex    Okay, thanks.  By the way, why would the tests fail? Because you left out the space character in the string.

Chip

[Isira Seneviratne]

On Mon, Aug 19, 2019, 5:15 AM Chip Davis <cdavis(a)codeweavers.com> wrote:
> August 18, 2019 5:51 PM, "Isira Seneviratne" <isirasen96(a)gmail.com
> <%22Isira%20Seneviratne%22%20%3Cisirasen96(a)gmail.com%3E>> wrote:
>
> On Mon, Aug 19, 2019, 1:42 AM Alex Henrie <alexhenrie24(a)gmail.com> wrote:
>
> + * Copyright (C) 2019 Isira Seneviratne
>
> - static const char expected[12] = "Hello World!";
> + static const char expected[12] = {
> 'H','e','l','l','o','W','o','r','l','d','!','\0' };
>
> All you had to do was remove the number 12 and let the compiler
> determine the size of the array automatically. And you really
> shouldn't add your name at the top of the file unless you wrote a
> substantial chunk of the file.
>
> -Alex
>
> Okay, thanks.
> By the way, why would the tests fail?
>
> Because you left out the space character in the string.
>
> Chip

Thanks a lot!

Isira
>