Re: [PATCH] windowscodecs/tests: Fix a test failure [newwtb and other]
5 Jul
2013
5 Jul
'13
11:43 a.m.
Detlef Riekenberg <wine.dev(a)web.de> wrote:
- /* global palette */ + /* global palette. This succeed since win7sp1 with platform update / win8 */
This comment is not helpful.
hr = IWICBitmapDecoder_CopyPalette(decoder, palette); - ok(hr == WINCODEC_ERR_FRAMEMISSING, - "expected WINCODEC_ERR_FRAMEMISSING, got %#x\n", hr); + ok((hr == S_OK) || (hr == WINCODEC_ERR_FRAMEMISSING), + "expected S_OK or WINCODEC_ERR_FRAMEMISSING, got %#x\n", hr);
One of test results should be marked as broken, and in the S_OK case the resulting palette should be tested and released. I'd guess that newer version should be taken as a model to follow, and Wine implementation should be fixed appropriately. -- Dmitry.
4546
Age (days ago)
4546
Last active (days ago)
0 comments
1 participants
participants (1)
-
Dmitry Timoshkov