Re: [3/6] WineD3D: Handle SM 3.0 varyings in ARB

[Allan Tong]

On Wed, Jun 17, 2009 at 1:37 PM, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> +                        if(strcmp(rel_reg, "**aL_emul**") == 0)
> +                        {
> +                            DWORD idx = ctx->aL + reg->idx;
> +                            if(idx < 10)

Seems like this should be MAX_REG_INPUT instead of 10.
> +                            {
> +                                strcpy(register_name, ctx->ps_input[reg->idx]);

Should this be "ctx->ps_input[idx]"?
> +                            }
> +                            else
> +                            {
> +                                ERR("Pixel shader input register out of bounds: %u\n", idx);
> +                                sprintf(register_name, "out_of_bounds_%u", idx);
> +                            }
> +                        }

- Allan

[3/6] WineD3D: Handle SM 3.0 varyings in ARB

[Stefan Dösinger]

Am Wednesday 17 June 2009 21:45:12 schrieb Allan Tong:
> On Wed, Jun 17, 2009 at 1:37 PM, Stefan Dösinger <stefan(a)codeweavers.com> 
> wrote:
> > +                        if(strcmp(rel_reg, "**aL_emul**") == 0)
> > +                        {
> > +                            DWORD idx = ctx->aL + reg->idx;
> > +                            if(idx < 10)
>
> Seems like this should be MAX_REG_INPUT instead of 10.
> > +                            {
> > +                                strcpy(register_name,
> > ctx->ps_input[reg->idx]);
> > Yep, in both cases you're right - thanks for catching that.

(This emulated aL varying indexing is kinda academic at this point since I 
don't intend to ever run 3.0 shaders without the proper NV extensions)