Re: ole32 [2/2] (msi [9.5/13]): Storage sharing should be implemented inole32, not the lower-level file API
"James Hawkins" <jhawkins(a)codeweavers.com> wrote:
- { FALSE, ERROR_SHARING_VIOLATION, FALSE }, - { TRUE, ERROR_SUCCESS, TRUE } + { TRUE, ERROR_SUCCESS }, + { TRUE, ERROR_SUCCESS }, + { TRUE, ERROR_SUCCESS }, + { TRUE, ERROR_SUCCESS }, + { FALSE, ERROR_SHARING_VIOLATION }, + { FALSE, ERROR_SHARING_VIOLATION }, + { FALSE, ERROR_SHARING_VIOLATION }, + { TRUE, ERROR_SUCCESS }, + { FALSE, ERROR_SHARING_VIOLATION }, + { FALSE, ERROR_SHARING_VIOLATION }, + { FALSE, ERROR_SHARING_VIOLATION }, + { TRUE, ERROR_SUCCESS }, + { FALSE, ERROR_SHARING_VIOLATION }, + { FALSE, ERROR_SHARING_VIOLATION }, + { FALSE, ERROR_SHARING_VIOLATION }, + { TRUE, ERROR_SUCCESS } };
You forgot to remove 'BOOL todo;' from struct access_res definition. Also making the arrays of structures 'static const' while you are at it won't hurt (same for other similar tests). -- Dmitry.
participants (1)
-
Dmitry Timoshkov