Visual changes after running tests

[Paul Vriens]

Hi,

with the latest winetest suite I've noticed the following changes:

- On win98 my taskbar get's twice the size it used to be.
- On win98/winxp the window border is a lot thicker.
- On winxp the icons in my taskbar are a lot bigger. And also the icons
in for example regedit.

the first and last one prevail (even after rebooting). The second one
seems to intermittently stay.

I'll have a look myself later on but just wanted some confirmation.

Cheers,

Paul.

[Rein Klazes]

On Sun, 20 Nov 2005 17:02:21 +0100, you wrote:
> Hi,
>
> with the latest winetest suite I've noticed the following changes:
>
> - On win98 my taskbar get's twice the size it used to be.
> - On win98/winxp the window border is a lot thicker.
> - On winxp the icons in my taskbar are a lot bigger. And also the icons
> in for example regedit.
>
> the first and last one prevail (even after rebooting). The second one
> seems to intermittently stay.
>
> I'll have a look myself later on but just wanted some confirmation.

The first one is definitely caused by my re-enabling of the
SPI_GET/SETBORDER tests in user/tests/sysparams.c. The problem here is
that the default border is 1, which is also the minimum accepted. If you
don't allow bigger borders (causing the task bar to expand) then there
cant be tests. No need for rebooting, you can easily correct it with the
mouse.

The second I don't see, but since it is about borders this could be the
same patch. Can you tell if the sysparams test is causing it?

Rein.

[Paul Vriens]

> On Sun, 20 Nov 2005 17:02:21 +0100, you wrote:
> > Hi,
> >
> > with the latest winetest suite I've noticed the following changes:
> >
> > - On win98 my taskbar get's twice the size it used to be.
> > - On win98/winxp the window border is a lot thicker.
> > - On winxp the icons in my taskbar are a lot bigger. And also the icons
> > in for example regedit.
> >
> > the first and last one prevail (even after rebooting). The second one
> > seems to intermittently stay.
> >
> > I'll have a look myself later on but just wanted some confirmation.
>
> The first one is definitely caused by my re-enabling of the
> SPI_GET/SETBORDER tests in user/tests/sysparams.c. The problem here is
> that the default border is 1, which is also the minimum accepted. If you
> don't allow bigger borders (causing the task bar to expand) then there
> cant be tests. No need for rebooting, you can easily correct it with the
> mouse.
>
> The second I don't see, but since it is about borders this could be the
> same patch. Can you tell if the sysparams test is causing it?
>
> Rein.

Hi Rein,

the problem with the big icons is due to the fact that (somehow)
CaptionWidth is changed.

One thing that doesn't look correct in tests/sysparams.c :

586     /* The SPI_SETBORDER seems to be buggy on Win9x/ME (looks like you
need to
587      * do it twice to make the intended change). So skip parts of the
tests on
588      * those platforms */
589     iswin9x = GetVersion() & 0x80000000;

and later on :

613     if( !iswin9x) {
614         test_setborder(1,  1, dpi);
615         test_setborder(0,  1, dpi);
616         test_setborder(7,  1, dpi);
617         test_setborder(20, 1, dpi);
618     }

so were doing the test twice if it's not win9x/ME ??

Cheers,

Paul.

[Paul Vriens]

> > On Sun, 20 Nov 2005 17:02:21 +0100, you wrote:
> > > Hi,
> > >
> > > with the latest winetest suite I've noticed the following changes:
> > >
> > > - On win98 my taskbar get's twice the size it used to be.
> > > - On win98/winxp the window border is a lot thicker.
> > > - On winxp the icons in my taskbar are a lot bigger. And also the icons
> > > in for example regedit.
> > >
> > > the first and last one prevail (even after rebooting). The second one
> > > seems to intermittently stay.
> > >
> > > I'll have a look myself later on but just wanted some confirmation.
> >
> > The first one is definitely caused by my re-enabling of the
> > SPI_GET/SETBORDER tests in user/tests/sysparams.c. The problem here is
> > that the default border is 1, which is also the minimum accepted. If you
> > don't allow bigger borders (causing the task bar to expand) then there
> > cant be tests. No need for rebooting, you can easily correct it with the
> > mouse.
> >
> > The second I don't see, but since it is about borders this could be the
> > same patch. Can you tell if the sysparams test is causing it?
> >
> > Rein.
>
> Hi Rein,
>
> the problem with the big icons is due to the fact that (somehow)
> CaptionWidth is changed.
>
> One thing that doesn't look correct in tests/sysparams.c :
>
> 586     /* The SPI_SETBORDER seems to be buggy on Win9x/ME (looks like you
> need to
> 587      * do it twice to make the intended change). So skip parts of the
> tests on
> 588      * those platforms */
> 589     iswin9x = GetVersion() & 0x80000000;
>
> and later on :
>
> 613     if( !iswin9x) {
> 614         test_setborder(1,  1, dpi);
> 615         test_setborder(0,  1, dpi);
> 616         test_setborder(7,  1, dpi);
> 617         test_setborder(20, 1, dpi);
> 618     }
>
> so were doing the test twice if it's not win9x/ME ??
>
> Cheers,
>
> Paul.

Forget the remark about the code. Should learn to read.

Paul.

[Rein Klazes]

On Mon, 21 Nov 2005 14:28:14 +0100 (CET), you wrote:
> the problem with the big icons is due to the fact that (somehow)
> CaptionWidth is changed.

I see it now, on XP in the Tele Tubby mode. Classic Windows is alright.

Hmm, it looks like the icons get bigger on about any SP_SETNONCLIENT
call. I need to think about this.

Rein.

[Detlef Riekenberg]

Am Sonntag, den 20.11.2005, 17:02 +0100 schrieb Paul Vriens:
> with the latest winetest suite I've noticed the following changes:
> Thanks for writing this first.
> - On win98 my taskbar get's twice the size it used to be.
> Same here on win98se
> - On win98/winxp the window border is a lot thicker.

On nt3.51 it chages from 3(default), 1 or 0 to to 20.
Looks very ugly.
> the first and last one prevail (even after rebooting). The second one
> seems to intermittently stay.
> I set this back manual on nt3.51.
> I will check with a reboot.
> I'll have a look myself later on but just wanted some confirmation.

You are not alone.

-- 
By By ...
      ... Detlef

Visual changes after running tests: fix

[Rein Klazes]

On Sun, 20 Nov 2005 17:02:21 +0100, you wrote:
> Hi,
>
> with the latest winetest suite I've noticed the following changes:
>
> - On win98 my taskbar get's twice the size it used to be.
> - On win98/winxp the window border is a lot thicker.
> - On winxp the icons in my taskbar are a lot bigger. And also the icons
> in for example regedit.

Attached patch fixes for me 1 and 3 and I have good hope 2 may be gone
as well. Tested on win95,ME,NT4,2k, XP and wine.

Changelog:
dlls/user/tests		: sysparams.c
Make test_SPI_SETBORDER less likely to permanently change visual
settings:
- use smaller border widths values for testing;
- provide a work around for a Windows XP feature that made the tests
change the caption width;

Rein.