Re: commctrl: dialog theming
I'm no longer able to run programs that require the native comctl32 and commctrl DLLs, since updating to today's CVS. Could it be related to these theme patches? It seems that now, if you override comctl32 for any app (or globally), even WineCfg itself will error out with the error. err:thunk:_loadthunk (commctrl.dll, Cctl1632_ThunkData16, comctl32.dll): Unable to load 'commctrl.dll', error 2 err:module:LdrInitializeThunk "comctl32.dll" failed to initialize, aborting err:module:LdrInitializeThunk Main exe initialization for L"c:\\windows\\system32\\winecfg.exe" failed, status c0000142 The native commctrl.dll and comctl32.dll both exist in my windows/system directory - the same versions that always worked before. Overriding commctrl doesn't have any effect on this error. -J Frank Richter wrote:
This patch assumes the listbox patch was applied before.
Frank Richter <frank.richter(a)gmail.com> Add theming support for dialogs (to support tab page background).
Hi, On Wed, Aug 17, 2005 at 06:35:21PM -0400, Evil wrote:
I'm no longer able to run programs that require the native comctl32 and commctrl DLLs, since updating to today's CVS. Could it be related to these theme patches?
It seems that now, if you override comctl32 for any app (or globally), even WineCfg itself will error out with the error.
err:thunk:_loadthunk (commctrl.dll, Cctl1632_ThunkData16, comctl32.dll): Unable to load 'commctrl.dll', error 2 err:module:LdrInitializeThunk "comctl32.dll" failed to initialize, aborting err:module:LdrInitializeThunk Main exe initialization for L"c:\\windows\\system32\\winecfg.exe" failed, status c0000142
The native commctrl.dll and comctl32.dll both exist in my windows/system directory - the same versions that always worked before. Overriding commctrl doesn't have any effect on this error. Just to verify: are you sure that you're *either* running both commctrl.dll and comctl32.dll as native *or* both commctrl.dll and comctl32.dll as builtin? Otherwise it *will* fail, with a thunk error similar (or equal?) to above.
-- GNU/Linux. It's not the software thats free, it's you.
Andreas Mohr wrote:
Just to verify: are you sure that you're
*either* running both commctrl.dll and comctl32.dll as native *or* both commctrl.dll and comctl32.dll as builtin? Otherwise it *will* fail, with a thunk error similar (or equal?) to above.
Yes, using both native is when I get the aforementioned failure. Dreamweaver starts if you use both built-in, but there are broken dialogs that can't be used. -J
Evil wrote:
I'm no longer able to run programs that require the native comctl32 and commctrl DLLs, since updating to today's CVS. Could it be related to these theme patches?
You shouldn't need to use the native comctl32 any longer. Please update your dll overrides to "comctl32" = "builtin". Wine's comctl32 implementation is almost complete. If there's bugs with the builtin comctl32 then please help us by reporting them rather than sweeping the problem under the carpet and using the native dll. Mike
Mike McCormack wrote:
You shouldn't need to use the native comctl32 any longer. Please update your dll overrides to "comctl32" = "builtin".
Wine's comctl32 implementation is almost complete. If there's bugs with the builtin comctl32 then please help us by reporting them rather than sweeping the problem under the carpet and using the native dll.
Dreamweaver's "Add Site" (and other) dialog are completely broken when using the built-in comctl32. This was known way before I ever started using WINE (because I learned of it by searching old mailing lists). I even added it to the app database months back. -Jesse
Evil wrote:
Dreamweaver's "Add Site" (and other) dialog are completely broken when using the built-in comctl32.
OK, there is a patch that is in CrossOver that has not yet been committed to WineHQ for some reason, that fixes this problem.
This was known way before I ever started using WINE (because I learned of it by searching old mailing lists). I even added it to the app database months back.
Could you please try the attached patch? I fear that Wine doesn't go forward as much as it should for lack of testing :/ Mike
Mike McCormack wrote:
Could you please try the attached patch?
I fear that Wine doesn't go forward as much as it should for lack of testing :/
The patch worked great! At least, it appears to work a lot better than before. There are still some graphical glitches, for example: If you switch server technology between yes and no when defining a site, the combo box doesn't completely reappear... but it's actually useable now! Please have this committed to CVS. Thanks Mike! Great Job! -Jesse
Thursday, August 18, 2005, 12:10:39 AM, Mike McCormack wrote:
Evil wrote:
I'm no longer able to run programs that require the native comctl32 and commctrl DLLs, since updating to today's CVS. Could it be related to these theme patches?
You shouldn't need to use the native comctl32 any longer. Please update your dll overrides to "comctl32" = "builtin".
Wine's comctl32 implementation is almost complete. If there's bugs with the builtin comctl32 then please help us by reporting them rather than sweeping the problem under the carpet and using the native dll.
To fuel this fire a little bit, I should mention that ATM all themed controls are broken with all Delphi and possible some other programs. So having an option to use native comctl32 is not such a bad idea. Vitaliy.
Vitaliy Margolen wrote:
...So having an option to use native comctl32 is not such a bad idea.
I couldn't agree more. I can't imagine that DreamWeaver's the only program that's broken (or will be broken, as new features are added and problems are worked out) when using the built-in implementation. I guess I'll backlevel for now, but I was loving playing with the newest DX patches. -J
Hi, I'm trying to have this app (http://appdb.winehq.org/appview.php?versionId=2451) with wine, but for the moment it requires native commctrl.dll && comctl32.dll, for installation (more linked with InstallShield than with app). What traces should I provide to help you with this ? Mike McCormack a écrit :
Evil wrote:
I'm no longer able to run programs that require the native comctl32 and commctrl DLLs, since updating to today's CVS. Could it be related to these theme patches?
You shouldn't need to use the native comctl32 any longer. Please update your dll overrides to "comctl32" = "builtin".
Wine's comctl32 implementation is almost complete. If there's bugs with the builtin comctl32 then please help us by reporting them rather than sweeping the problem under the carpet and using the native dll.
Mike
participants (5)
-
Andreas Mohr -
Dripple -
Evil -
Mike McCormack -
Vitaliy Margolen