Re: [1/2] msvcrt: Add tmpfile_s implementation (resend)

[Alexandre Julliard]

André Hentschel <nerv(a)dawncrow.de> writes:
> +int CDECL MSVCRT_tmpfile_s(MSVCRT_FILE** file)
> +{
> +    if (!file) {
> +        *MSVCRT__errno() = MSVCRT_EINVAL;
> +        return MSVCRT_EINVAL;
> +    }

That's not the right way to check parameters in _s functions.

-- 
Alexandre Julliard
julliard(a)winehq.org

[1/2] msvcrt: Add tmpfile_s implementation (resend)

[André Hentschel]

Am 13.03.2012 10:34, schrieb Alexandre Julliard:
> André Hentschel <nerv(a)dawncrow.de> writes:
> > +int CDECL MSVCRT_tmpfile_s(MSVCRT_FILE** file)
> > +{
> > +    if (!file) {
> > +        *MSVCRT__errno() = MSVCRT_EINVAL;
> > +        return MSVCRT_EINVAL;
> > +    }
>
> That's not the right way to check parameters in _s functions.

The other way would be to use MSVCRT_CHECK_PMT, but the tests show that this is not correct.


-- 

Best Regards, André Hentschel