[PATCH 2/9] server: Introduce CurrentIn device.

[Jacek Caban]

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
---
  server/console.c   | 60 ++++++++++++++++++++++++++++++++++++++++++++++
  server/directory.c |  9 ++++++-
  server/file.h      |  1 +
  3 files changed, 69 insertions(+), 1 deletion(-)

[Alexandre Julliard]

Jacek Caban <jacek(a)codeweavers.com> writes:
> @@ -412,6 +414,11 @@ void init_directories(void)
>      create_session( 0 );
>      create_session( 1 );
>
> +    /* console */
> +    dir_console = create_directory( &dir_device->obj, &dir_condrv_str, 0, HASH_SIZE, NULL );
> +    create_console_devices( &dir_console->obj );
> +    release_object( dir_console );

Shouldn't ConDrv be a driver instead of a directory?  It could simply
handle CurrentIn etc. in its lookup_name() function.

-- 
Alexandre Julliard
julliard(a)winehq.org

[Jacek Caban]

On 25.06.2020 10:15, Alexandre Julliard wrote:
> Jacek Caban <jacek(a)codeweavers.com> writes:
> > @@ -412,6 +414,11 @@ void init_directories(void)
> >       create_session( 0 );
> >       create_session( 1 );
> >
> > +    /* console */
> > +    dir_console = create_directory( &dir_device->obj, &dir_condrv_str, 0, HASH_SIZE, NULL );
> > +    create_console_devices( &dir_console->obj );
> > +    release_object( dir_console );
> > Shouldn't ConDrv be a driver instead of a directory?  It could simply
> > handle CurrentIn etc. in its lookup_name() function.

Yes, that works better, I sent a new version.


Thanks,

Jacek