Re: [PATCH] schannel_gnutls: when calling pgnutls_server_name_set ensure that the values are sane

[Jacek Caban]

Hi Nikos,

On 03/27/15 17:25, Nikos Mavrogiannopoulos wrote:
> This patch addresses issue with schan_imp_set_session_target()
> translation to gnutls API. It does not pass invalid (null) parameters to
> it, as this seems to cause issues. Addresses
> https://bugs.winehq.org/show_bug.cgi?id=38134

Take a look at schan_imp_set_session_target caller in schannel.c. It
already ensures that passed target is not NULL. If your patch indeed
fixes a real problem, it's probably because it also ignores an empty
string. That's, however, something that should also be done on caller side.

Thanks,
Jacek