[2/2] riched20: Implement {ITextRange,ITextSelection}::MoveEnd in case tomStory.

[Jactry Zeng]

Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com>
---
  dlls/riched20/richole.c       |  54 ++++++++++++++++++--
  dlls/riched20/tests/richole.c | 115 
++++++++++++++++++++++++++++++++++++++++++
  2 files changed, 165 insertions(+), 4 deletions(-)

[Huw Davies]

On Mon, Apr 02, 2018 at 12:08:15PM +0800, Jactry Zeng wrote:
> static HRESULT WINAPI ITextRange_fnMoveWhile(ITextRange *me, VARIANT *charset, LONG count,
> @@ -4695,12 +4741,12 @@ static HRESULT WINAPI ITextSelection_fnMoveEnd(ITextSelection *me, LONG unit, LO
>  {
>      ITextSelectionImpl *This = impl_from_ITextSelection(me);
>
> -    FIXME("(%p)->(%d %d %p): stub\n", This, unit, count, delta);
> +    TRACE("(%p)->(%d %d %p)\n", This, unit, count, delta);
>
> if (!This->reOle)
>          return CO_E_RELEASED;
>
> -    return E_NOTIMPL;
> +    return textrange_moveend((ITextRange*)me, unit, count, delta);

The cast here is messy (I know ITextSelection inherits ITextRange, but still).
You should probably get a ITextRange ptr by calling QueryInterface.

Huw.

[2/2] riched20: Implement {ITextRange, ITextSelection}::MoveEnd in case tomStory.

[Jactry Zeng]

Thanks for review! I sent a new one.

2018-04-03 17:00 GMT+08:00 Huw Davies <huw(a)codeweavers.com>:
> On Mon, Apr 02, 2018 at 12:08:15PM +0800, Jactry Zeng wrote:
> > static HRESULT WINAPI ITextRange_fnMoveWhile(ITextRange *me, VARIANT
> > *charset, LONG count,
> > @@ -4695,12 +4741,12 @@ static HRESULT WINAPI ITextSelection_fnMoveEnd(ITextSelection
> > *me, LONG unit, LO
> >  {
> >      ITextSelectionImpl *This = impl_from_ITextSelection(me);
> >
> > -    FIXME("(%p)->(%d %d %p): stub\n", This, unit, count, delta);
> > +    TRACE("(%p)->(%d %d %p)\n", This, unit, count, delta);
> >
> > if (!This->reOle)
> >          return CO_E_RELEASED;
> >
> > -    return E_NOTIMPL;
> > +    return textrange_moveend((ITextRange*)me, unit, count, delta);
>
> The cast here is messy (I know ITextSelection inherits ITextRange, but
> still).
> You should probably get a ITextRange ptr by calling QueryInterface.
>
> Huw.

-- 
Regards,
Jactry Zeng