Re: [PATCH 3/3] gdiplus/tests: Added tests for GdipCreateStreamOnFile.

[Dmitry Timoshkov]

Qian Hong <qhong(a)codeweavers.com> wrote:
> +static void test_gdipstream(void)
> +{
> +    IStream *stream;
> +    WCHAR nonexistentW[] = {'n','o','n','e','x','i','s','t','.','b','m','p','\0'};
> +    WCHAR nonshareW[] = {'n','o','n','s','h','a','r','e','.','b','m','p','\0'};
> +    GpStatus stat;
> +    HANDLE hfile;
> +
> +    hfile = CreateFileW(nonshareW, GENERIC_READ, 0, NULL, CREATE_NEW, FILE_FLAG_DELETE_ON_CLOSE, 0);
> +    ok(hfile != INVALID_HANDLE_VALUE, "failed to create file\n");

Same problem with temp files in current directory.
> +    stream = (IStream *)0xdeadcafe;
> +    stat = GdipCreateStreamOnFile(nonexistentW, GENERIC_READ, &stream);
> +    todo_wine ok(stat == NotImplemented, "returned %d, expected NotImplemented\n", stat);
> +    todo_wine ok(stream == (IStream *)0xdeadcafe, "returned %p\n", stream);
> +
> +    stream = (IStream *)0xdeadcafe;
> +    stat = GdipCreateStreamOnFile(nonshareW, GENERIC_READ, &stream);
> +    todo_wine ok(stat == NotImplemented, "returned %d, expected NotImplemented\n", stat);
> +    todo_wine ok(stream == (IStream *)0xdeadcafe, "returned %p\n", stream);
> +
> +    CloseHandle(hfile);
> +}

Please use common 0xdeadbeef instead of new inventions.

-- 
Dmitry.