Re: [PATCH 1/4] kernel32: add test for WaitForSingleObject with lower 2 bits of handles set

[Paul Vriens]

On 09/22/2010 07:53 PM, Peter Oberndorfer wrote:
> +    if(GetVersion()&  0x80000000)
> +    {
> +        win_skip("Handles work differently on win9x\n");
> +        return;
> +    }
> +
> +    signaled = CreateEventW(NULL, TRUE, TRUE, NULL);

Hi Peter,

You could just as easily check for the last error of CreateEventW which 
would be ERROR_CALL_NOT_IMPLEMENTED on win9x/winME. This is usually 
prefered above GetVersion(). I must say that I do see other GetVersion() 
calls in the kernel32 tests.

The fact that you are using win_skip will make the tests fail if you run 
Wine in Win98 mode, but I guess nobody does that.

-- 
Cheers,

Paul.