Re: [1/4] user32/tests: Test size and minmax of WS_THICKFRAME child.

[Austin English]

On Sun, Nov 16, 2008 at 10:52 AM, Florian Köberle <florian(a)fkoeberle.de> wrote:
> Patch to fix bug 15188.
>
> This work is based on:
> http://www.winehq.org/pipermail/wine-patches/2008-October/062460.html
>
> In this new patch series I calculate size like this:
>
> const int outer = 2;
> int resizeBorder = GetSystemMetrics(SM_CXFRAME) -
> GetSystemMetrics(SM_CXDLGFRAME);
> int size =  2*(outer + resizeBorder);
>
> I took this formular from dlls/user32/nonclient.c:
> ------------------
>        adjust = 0;
>        if ((exStyle & WS_EX_DLGMODALFRAME) ||
>            (style & (WS_THICKFRAME|WS_DLGFRAME))) adjust = 2; /* outer */
>    }
>    if (style & WS_THICKFRAME)
>        adjust +=  ( GetSystemMetrics (SM_CXFRAME)
>                   - GetSystemMetrics (SM_CXDLGFRAME)); /* The resize
> border */
> ------------------
>
> While writing this test I also tried some other styles and compared the
> behavior between
> CreateWindowEx and AdjustWindowRectEx. It didn't look like they have
> much in common, that is why I didn't wrote the test against
> AdjustWindowRectEx.
>
> Best regards,
> Florian

> From 762f49e2192b6d8477826c6535ef1ba0e1fd9d9b Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?Florian=20K=C3=B6berle?= <florian(a)fkoeberle.de>

Looks like you've botched the encoding somehow...
> +    test_thick_child_size(hwndMain); // causes test_capture_2() to fail

Don't use C++ style comments, use C (/* comment */) instead.
-- 
-Austin

[1/4] user32/tests: Test size and minmax of WS_THICKFRAME child.

[Florian Köberle]

Hi Austin,
> > From 762f49e2192b6d8477826c6535ef1ba0e1fd9d9b Mon Sep 17 00:00:00 2001
> > From: =?utf-8?q?Florian=20K=C3=B6berle?= <florian(a)fkoeberle.de>
>
> Looks like you've botched the encoding somehow...

That's correct this way. If you have a look at other mails you will see
that it is similar:
e.g.

From: =?utf-8?q?J=C3=A9r=C3=B4me=20Gardou?=
> > +    test_thick_child_size(hwndMain); // causes test_capture_2() to fail
>
> Don't use C++ style comments, use C (/* comment */) instead.

I will fix that. Thanks for telling.


Best regards,
Florian