Re: [PATCH 2/3] d3dx9_36: Store all values passed to the create and return them in the correct functions
2015-12-23 7:47 GMT+01:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>:
static ULONG WINAPI d3dx9_animation_controller_AddRef(ID3DXAnimationController *iface) { - struct d3dx9_animation_controller *animation = impl_from_ID3DXAnimationController(iface); - ULONG refcount = InterlockedIncrement(&animation->ref); + struct d3dx9_animation_controller *This = impl_from_ID3DXAnimationController(iface); + ULONG refcount = InterlockedIncrement(&This->ref);
- TRACE("%p increasing refcount to %u.\n", animation, refcount); + TRACE("%p increasing refcount to %u.\n", This, refcount);
These changes don't seem useful, especially considering that these lines were introduced in the previous patch. More of it below, same comment applies. FWIW I prefer "animation" to "This".
participants (1)
-
Matteo Bruni