Version information in hhctrl.ocx breaks hhupd.exe

Hello!

I have noticed that in the last few days the native hhctrl.ocx doesn't
installs anymore. Both the automatically installation in Internet
Explorer and the manually start of Microsofts hhupd.exe fails with the
message "This computer already has a newer version of HTML Help."

I found out that integrating version information in the builtin 
hhctrl.ocx caused this effect. Look into the newest version of 
wine/dlls/hhctrl.ocx/Makefile.in and version.rc.

Is this done wilfully or is it a bug?

Thanks, Sven

[Saulius Krasuckas]

On Thu, 18 Nov 2004, Sven Paschukat wrote:
> I have noticed that in the last few days the native hhctrl.ocx doesn't
> installs anymore. Both the automatically installation in Internet
> Explorer and the manually start of Microsofts hhupd.exe fails with the
> message "This computer already has a newer version of HTML Help."
>
> I found out that integrating version information in the builtin 
> hhctrl.ocx caused this effect. Look into the newest version of 
> wine/dlls/hhctrl.ocx/Makefile.in and version.rc.
>
> Is this done wilfully or is it a bug?

Whatever it be, same effect shows up during the install of DCOM98 update,
IMHO.  Easy way to escape from this should be to hide builtin, "newer"
version of this binary.  

It can be done just by setting Wine to use only the native version of
hhctrl.ocx, AFAIK:

$ WINEDLLOVERRIDES="hhctrl.ocx=n" wine ...
or 
$ WINEDLLOVERRIDES="hhctrl=n" wine ...

(cannot remember correct format for the name of the hhtcrl.ocx library ATM)

[Hans Leidekker]

On Thursday 18 November 2004 01:31, Sven Paschukat wrote:
> I found out that integrating version information in the builtin 
> hhctrl.ocx caused this effect. Look into the newest version of 
> wine/dlls/hhctrl.ocx/Makefile.in and version.rc.
>
> Is this done wilfully or is it a bug?

Well, not having version information in hhctrl.ocx breaks other applications
(see the thread on the WinZip 10 installer which triggered me to send that
 patch).

The native version of hhctrl.ocx has version information, and so should
Wine's. It could very well be that this breaks more apps than it fixes,
but sometimes that's the price you have to pay for making progress.

Let's hope that this change itches some capable developer enough to do 
some serious scratching... ;-)

 -Hans

[Tom]

Hans Leidekker wrote:
> Well, not having version information in hhctrl.ocx breaks other applications
> (see the thread on the WinZip 10 installer which triggered me to send that
>  patch).

Hello,

Would setting the version to 4.72.7323 allow Winzip 10 to install?
And a newer version of the native hhctrl.ocx would see that it needs 
updating and install without error?


Tom
> The native version of hhctrl.ocx has version information, and so should
> Wine's. It could very well be that this breaks more apps than it fixes,
> but sometimes that's the price you have to pay for making progress.
>
> Let's hope that this change itches some capable developer enough to do 
> some serious scratching... ;-)
>
> -Hans

[Saulius Krasuckas]

On Thu, 18 Nov 2004, Sven Paschukat wrote:
> I have noticed that in the last few days the native hhctrl.ocx doesn't
> installs anymore. Both the automatically installation in Internet
> Explorer and the manually start of Microsofts hhupd.exe fails with the
> message "This computer already has a newer version of HTML Help."

I have run three different hhupd.exe files just a second ago and all of
them told me this:  "HTML Help Setup completed.".

What version of windows is your Wine set to behave like?

$ grep '^[^#;]' ~/.wine/config | grep -A1 '\[Version\]'
[Version]
"Windows" = "win98"


And what version of Wine are you using?  Mine is latest CVS.

Saulius:
> It can be done just by setting Wine to use only the native version of
> hhctrl.ocx, AFAIK:
>
> $ WINEDLLOVERRIDES="hhctrl.ocx=n" wine ...
> or
> $ WINEDLLOVERRIDES="hhctrl=n" wine ...

Ok, first command works.


Saulius:
> What version of windows is your Wine set to behave like?
> And what version of Wine are you using?  Mine is latest CVS.

I'm using fresh .wine directory und initial config with no windows 
version set. And i am using latest CVS, too. Setting windows version to 
"win98" has no effect.

My hhupd.exe is version 4.71.1015.0 with hhctrl.ocx version 4.74.8875.


Hans:
> The native version of hhctrl.ocx has version information,
> and so should Wine's. It could very well be that this breaks
> more apps than it fixes, but sometimes that's the price you
> have to pay for making progress.

What about Tom's suggestion setting a more realistic -lower- version in 
builtin hhctrl.ocx? Version number 10.0 is good for applications needing 
hhelp functionality, but not for them with installers.

Thanks, Sven

[Hans Leidekker]

On Thursday 18 November 2004 22:45, Sven Paschukat wrote:
> What about Tom's suggestion setting a more realistic -lower- version in 
> builtin hhctrl.ocx? Version number 10.0 is good for applications needing 
> hhelp functionality, but not for them with installers.

Yes, that may work if there is a version number sufficiently high for apps
to accept it and at the same time low enough for the updater to do an upgrade.
Feel free to submit a patch...

 -Hans

[Tom]

Hans Leidekker wrote:
> On Thursday 18 November 2004 22:45, Sven Paschukat wrote:
> > What about Tom's suggestion setting a more realistic -lower- version in 
> > builtin hhctrl.ocx? Version number 10.0 is good for applications needing 
> > hhelp functionality, but not for them with installers.
>
> Yes, that may work if there is a version number sufficiently high for apps
> to accept it and at the same time low enough for the updater to do an upgrade.
> Feel free to submit a patch...
>
> -Hans

Here is version 1.1a (4.72.7325) but we could go with 1.21 the version 
that shipped with win 2K (4.73.8412) and IE 5.5 onward will still 
update. and (4.74.8875) is version 1.32 btw...

Any preference?

Tom

/*
 * Version information for hhctrl.ocx
 *
 * Copyright 2004 Hans Leidekker
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 */

#define WINE_FILEDESCRIPTION_STR "Wine htmlhelp OCX"
#define WINE_FILENAME_STR "hhctrl.ocx"
#define WINE_FILEVERSION 4,72,7325
#define WINE_FILEVERSION_STR "4.72.7325"
#define WINE_PRODUCTVERSION 4,72,7325
#define WINE_PRODUCTVERSION_STR "4.72.7325"
#define WINE_PRODUCTNAME_STR "htmlhelp"

#include <wine/wine_common_ver.rc>

Tom schrieb:
> Here is version 1.1a (4.72.7325) but we could go with 1.21 the version 
> that shipped with win 2K (4.73.8412) and IE 5.5 onward will still 
> update. and (4.74.8875) is version 1.32 btw...
>
> Any preference?

I have had to append the WINE_FILEVERSION und WINE_PRODUCTVERSION with a 
",0" to avoid a parser error, but then it compiles.

The 4.72.7325.0 is ok i think. In my tests it runs with IE5, IE6, Winzip 
9.0 and the hhupd.exe itself.

Sven

/*
 * Version information for hhctrl.ocx
 *
 * Copyright 2004 Hans Leidekker
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 */

#define WINE_FILEDESCRIPTION_STR "Wine htmlhelp OCX"
#define WINE_FILENAME_STR "hhctrl.ocx"
#define WINE_FILEVERSION 4,72,7325,0
#define WINE_FILEVERSION_STR "4.72.7325.0"
#define WINE_PRODUCTVERSION 4,72,7325,0
#define WINE_PRODUCTVERSION_STR "4.72.7325.0"
#define WINE_PRODUCTNAME_STR "htmlhelp"

#include <wine/wine_common_ver.rc>

[Tom]

Sven Paschukat wrote:
> Tom schrieb:
> > Here is version 1.1a (4.72.7325) but we could go with 1.21 the version 
> > that shipped with win 2K (4.73.8412) and IE 5.5 onward will still 
> > update. and (4.74.8875) is version 1.32 btw...
> >
> > Any preference?
>
> I have had to append the WINE_FILEVERSION und WINE_PRODUCTVERSION with a 
> ",0" to avoid a parser error, but then it compiles.

:-)
> The 4.72.7325.0 is ok i think. In my tests it runs with IE5, IE6, Winzip 
> 9.0 and the hhupd.exe itself.

Can you give the Winzip 10 install a try?

Tom
> Sven

[Tom]

Tom wrote:
> > The 4.72.7325.0 is ok i think. In my tests it runs with IE5, IE6, 
> > Winzip 9.0 and the hhupd.exe itself.
>
> Can you give the Winzip 10 install a try?

I cant find WinZip 10 ... I thought they may of had a beta out
that is why I ask about it. I guess Hans ment WinZip 9 SR1 in
this post.

http://www.winehq.org/hypermail/wine-devel/2004/11/0412.html

Tom

[Adam Babcock]

Tom wrote:
> Tom wrote:
> > > The 4.72.7325.0 is ok i think. In my tests it runs with IE5, IE6, 
> > > Winzip 9.0 and the hhupd.exe itself.
> >
> > Can you give the Winzip 10 install a try?
>
> I cant find WinZip 10 ... I thought they may of had a beta out
> that is why I ask about it. I guess Hans ment WinZip 9 SR1 in
> this post.
>
> http://www.winehq.org/hypermail/wine-devel/2004/11/0412.html
>
> Tom

There is no winzip10, you are correct.

[Hans Leidekker]

On Sunday 21 November 2004 03:23, Tom wrote:
> I cant find WinZip 10 ... I thought they may of had a beta out
> that is why I ask about it. I guess Hans ment WinZip 9 SR1 in
> this post.
>
> http://www.winehq.org/hypermail/wine-devel/2004/11/0412.html

Yes I should have written 9, not 10, sorry. I just gave your patch a 
try with WinZip 9 again and it installs fine. But I think you should
leave the #define WINE_PRODUCTNAME_STR "Wine" out of your patch because
that's not different from what is defined in <wine/wine_common_ver.rc>

 -Hans

[Andreas Mohr]

Hi,

On Sat, Nov 20, 2004 at 04:40:09PM +0100, Sven Paschukat wrote:
> #define WINE_FILEDESCRIPTION_STR "Wine htmlhelp OCX"
> #define WINE_FILENAME_STR "hhctrl.ocx"
> #define WINE_FILEVERSION 4,72,7325,0
> #define WINE_FILEVERSION_STR "4.72.7325.0"
> #define WINE_PRODUCTVERSION 4,72,7325,0
> #define WINE_PRODUCTVERSION_STR "4.72.7325.0"
> #define WINE_PRODUCTNAME_STR "htmlhelp"
> If the version is so problematic, then why is there no comment about it? :-\

Andreas Mohr

[Tom]

Andreas Mohr wrote:
> Hi,
>
> On Sat, Nov 20, 2004 at 04:40:09PM +0100, Sven Paschukat wrote:
> > #define WINE_FILEDESCRIPTION_STR "Wine htmlhelp OCX"
> > #define WINE_FILENAME_STR "hhctrl.ocx"
> > #define WINE_FILEVERSION 4,72,7325,0
> > #define WINE_FILEVERSION_STR "4.72.7325.0"
> > #define WINE_PRODUCTVERSION 4,72,7325,0
> > #define WINE_PRODUCTVERSION_STR "4.72.7325.0"
> > #define WINE_PRODUCTNAME_STR "htmlhelp"
>
> If the version is so problematic, then why is there no comment about it? :-\

I'm just trying to find a happy medium so it works if you want native or 
builtin hhctrl.ocx

Tom
> Andreas Mohr