Re: [PATCH 2/2] wined3d: improved ATI Radeon HD 4xxx detection

[Stefan Dösinger]

The patches seem ok to me, although I'd probably merge  them into one 
patch(there's no point in adding unused defines)

[PATCH 2/2] wined3d: improved ATI Radeon HD 4xxx detection

[Yann Droneaud]

Le mercredi 17 juin 2009 à 04:01 +0200, Stefan Dösinger a écrit :
> The patches seem ok to me, although I'd probably merge  them into one 
> patch(there's no point in adding unused defines)

In my first version, I tried to match each model because inside each
sub family, some are faster than the other.

According to Internet sources
like http://en.wikipedia.org/wiki/Radeon_R700 and 
http://en.wikipedia.org/wiki/Comparison_of_ATI_graphics_processing_units#Rad...

HD4350 and HD4550 have quite the same horse power, based on RV710.
HD4650 and HD4670 have quite the same horse power, based on RV730.

HD4700 is reported by AMD to be based on RV770, while HD4770 is based on
RV740. See
http://developer.amd.com/drivers/pc_vendor_id/Pages/default.aspx

HD48xx uses RV770 but not HD4890 which uses RV790.

According to benchmark, HD4770 is "faster" than HD4830.

Upcoming (rumored) HD4790 based on RV790 is said to be faster than
HD4850 or even HD4870.
http://www.techpowerup.com/index.php?96859

Note that the patch doesn't take account of HD48xx X2 card model based
on R700 which are reported to be way faster than all the others.

So the point was to match card and sort them by "power" instead of
family.
But it seems not doable since OpenGL renderer string like "ATI Radeon HD
4800 Series" is not useful to distinguish between HD4890 and HD4850 :(

Regards.

-- 
Yann Droneaud

[PATCH 2/2] wined3d: improved ATI Radeon HD 4xxx detection

[Roderick Colenbrander]

On Wed, Jun 17, 2009 at 10:16 AM, Yann Droneaud<yann(a)droneaud.fr> wrote:
> Le mercredi 17 juin 2009 à 04:01 +0200, Stefan Dösinger a écrit :
> > The patches seem ok to me, although I'd probably merge  them into one
> > patch(there's no point in adding unused defines)
>
> In my first version, I tried to match each model because inside each
> sub family, some are faster than the other.
>
> According to Internet sources
> like http://en.wikipedia.org/wiki/Radeon_R700 and
> http://en.wikipedia.org/wiki/Comparison_of_ATI_graphics_processing_units#Rad...
>
> HD4350 and HD4550 have quite the same horse power, based on RV710.
> HD4650 and HD4670 have quite the same horse power, based on RV730.
>
> HD4700 is reported by AMD to be based on RV770, while HD4770 is based on
> RV740. See
> http://developer.amd.com/drivers/pc_vendor_id/Pages/default.aspx
>
> HD48xx uses RV770 but not HD4890 which uses RV790.
>
> According to benchmark, HD4770 is "faster" than HD4830.
>
> Upcoming (rumored) HD4790 based on RV790 is said to be faster than
> HD4850 or even HD4870.
> http://www.techpowerup.com/index.php?96859
>
> Note that the patch doesn't take account of HD48xx X2 card model based
> on R700 which are reported to be way faster than all the others.
>
> So the point was to match card and sort them by "power" instead of
> family.
> But it seems not doable since OpenGL renderer string like "ATI Radeon HD
> 4800 Series" is not useful to distinguish between HD4890 and HD4850 :(
>
> Regards.
>
> --
> Yann Droneaud

The patch is good and you are correctly merging boards. Stefan his
point was that next time you should merge both patches into one file
as adding unused defines (the first patch) has zero effect without the
second patch, so they should be one patch.

Roderick