Testbot not accepting patch
Hi there, I've been trying to submit this patch to the testbot, and it keeps refusing it with the error "Unrecognized file typea" (that's not a typo, that's the exact error). The testbot has also refused to accept the patch when I sent it in on wine-patches (the error on the patch status page is apply failure). As far as I can tell, the patch looks good, it was generated by git format-patch from the latest git and I did not touch it after that, so it should apply, but it doesn't. Can you look into this? Thanks, Travis. -- Travis Athougies
On 1/14/11 3:20 PM, Travis Athougies wrote:
Hi there,
I've been trying to submit this patch to the testbot, and it keeps refusing it with the error "Unrecognized file typea" (that's not a typo, that's the exact error). The testbot has also refused to accept the patch when I sent it in on wine-patches (the error on the patch status page is apply failure). As far as I can tell, the patch looks good, it was generated by git format-patch from the latest git and I did not touch it after that, so it should apply, but it doesn't. Can you look into this?
Travis: It applied just fine to my git here. I did not attempt to build Wine, would you like me to? James McKenzie
On 01/14/2011 11:20 PM, Travis Athougies wrote:
Hi there,
I've been trying to submit this patch to the testbot, and it keeps refusing it with the error "Unrecognized file typea" (that's not a typo, that's the exact error). The testbot has also refused to accept the patch when I sent it in on wine-patches (the error on the patch status page is apply failure). As far as I can tell, the patch looks good, it was generated by git format-patch from the latest git and I did not touch it after that, so it should apply, but it doesn't. Can you look into this?
That attached patch doesn't contain a test. Could that be it? -- Cheers, Paul.
Am 15.01.2011 11:50, schrieb Paul Vriens:
On 01/14/2011 11:20 PM, Travis Athougies wrote:
Hi there,
I've been trying to submit this patch to the testbot, and it keeps refusing it with the error "Unrecognized file typea" (that's not a typo, that's the exact error). The testbot has also refused to accept the patch when I sent it in on wine-patches (the error on the patch status page is apply failure). As far as I can tell, the patch looks good, it was generated by git format-patch from the latest git and I did not touch it after that, so it should apply, but it doesn't. Can you look into this?
That attached patch doesn't contain a test. Could that be it?
definitly :) -- Best Regards, André Hentschel
On 15 January 2011 11:50, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
That attached patch doesn't contain a test. Could that be it?
Even if it did though, I imagine naming it 1/4 when it's not actually part of a series isn't going to help with the bot picking it up automatically. And of course that patch really *should* have an associated test.
From: Paul Vriens [mailto:paul.vriens.wine(a)gmail.com]
On 01/14/2011 11:20 PM, Travis Athougies wrote:
Hi there,
I've been trying to submit this patch to the testbot, and it keeps refusing it with the error "Unrecognized file typea" (that's not a typo, that's the exact error). The testbot has also refused to accept the patch when I sent it in on wine-patches (the error on the patch status page is apply failure). As far as I can tell, the patch looks good, it was generated by git format-patch from the latest git and I did not touch it after that, so it should apply, but it doesn't. Can you look into this?
That attached patch doesn't contain a test. Could that be it?
Yes, that's indeed the problem. When you submit a file to the bot, one of the first things it does is try to determine the file type (could be a patch or a cross-compiled .exe (either 32 or 64 bit)). The regular expression used to check for patches only recognized changes to files in .../tests directories, so it never matched for this patch. I'll grant you that the error message is less than ideal. I've changed the parsing, if it now recognizes a patch that doesn't make changes to any tests file it will tell you "Patch doesn't affect tests" (and I've also fixed the typo in the original error message). There is no need to submit patches to the bot that only contain changes to the core Wine code and not to the tests. Since TestBot only runs tests on Windows, it only cares about the test code and not the core Wine code. You'll have to take up the apply failure on the status page with Alexandre. That message has nothing to do with the bot. Since the patch applied without problems for me too, it seems you might have caught Alexandre on a little mistake :-) (don't we all love it when we get confirmation that he's human?). Greg.
Greg Geldorp <ggeldorp(a)vmware.com> writes:
You'll have to take up the apply failure on the status page with Alexandre. That message has nothing to do with the bot. Since the patch applied without problems for me too, it seems you might have caught Alexandre on a little mistake :-) (don't we all love it when we get confirmation that he's human?).
$ git apply 70225 error: patch failed: dlls/d3dx9_36/shader.c:874 error: dlls/d3dx9_36/shader.c: patch does not apply $ Guess I'm not human after all ;-) -- Alexandre Julliard julliard(a)winehq.org
From: Alexandre Julliard
Greg Geldorp <ggeldorp(a)vmware.com> writes:
You'll have to take up the apply failure on the status page with Alexandre. That message has nothing to do with the bot. Since the patch applied without problems for me too, it seems you might have caught Alexandre on a little mistake :-) (don't we all love it when we get confirmation that he's human?).
$ git apply 70225 error: patch failed: dlls/d3dx9_36/shader.c:874 error: dlls/d3dx9_36/shader.c: patch does not apply $
Guess I'm not human after all ;-)
Turns out that Travis decided to confuse us by attaching a slightly different patch to the first message of this thread on wine-devel compared to the patch that he sent to wine-patches. The wine-patches one doesn't apply, the wine-devel one does. Anyway, glad we sorted this out, I hate it when I have to adjust my view of the world. Greg.
On 1/15/11 8:53 AM, Greg Geldorp wrote:
From: Alexandre Julliard
Greg Geldorp<ggeldorp(a)vmware.com> writes:
You'll have to take up the apply failure on the status page with Alexandre. That message has nothing to do with the bot. Since the patch applied without problems for me too, it seems you might have caught Alexandre on a little mistake :-) (don't we all love it when we get confirmation that he's human?). $ git apply 70225 error: patch failed: dlls/d3dx9_36/shader.c:874 error: dlls/d3dx9_36/shader.c: patch does not apply $
Guess I'm not human after all ;-) Turns out that Travis decided to confuse us by attaching a slightly different patch to the first message of this thread on wine-devel compared to the patch that he sent to wine-patches. The wine-patches one doesn't apply, the wine-devel one does. Anyway, glad we sorted this out, I hate it when I have to adjust my view of the world.
Looks like it is time for [Try X] and a resubmission of the patch then. I was confused as well until I tried it on my local git and it also failed/passed. James McKenzie
participants (7)
-
Alexandre Julliard -
André Hentschel -
Greg Geldorp -
Henri Verbeet -
James McKenzie -
Paul Vriens -
Travis Athougies