Re: [1/2] wininet/tests: Add test for using NULL as proxy server.

[Jacek Caban]

Hi Sebastian,

On 10/08/15 07:15, Sebastian Lackner wrote:
> Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de>
> ---
>
> Testbot is broken again, so here a link to a run with precompiled test:
> https://newtestbot.winehq.org/JobDetails.pl?Key=17153
>
> dlls/wininet/tests/internet.c |   29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)

It fails here:

fixme:wininet:query_global_option INTERNET_OPTION_PER_CONNECTION_OPTION stub
fixme:wininet:get_proxy_autoconfig_url no support on this platform
fixme:wininet:query_global_option INTERNET_OPTION_PER_CONNECTION_OPTION stub
fixme:wininet:get_proxy_autoconfig_url no support on this platform
fixme:wininet:query_global_option INTERNET_OPTION_PER_CONNECTION_OPTION stub
internet.c:1387: Test failed: InternetSetOption should've succeeded

Cheers,
Jacek

[1/2] wininet/tests: Add test for using NULL as proxy server.

[Sebastian Lackner]

On 08.10.2015 12:15, Jacek Caban wrote:
> Hi Sebastian,
>
> On 10/08/15 07:15, Sebastian Lackner wrote:
> > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de>
> > ---
> >
> > Testbot is broken again, so here a link to a run with precompiled test:
> > https://newtestbot.winehq.org/JobDetails.pl?Key=17153
> >
> > dlls/wininet/tests/internet.c |   29 +++++++++++++++++++++++++++++
> >  1 file changed, 29 insertions(+)
>
> It fails here:
>
> fixme:wininet:query_global_option INTERNET_OPTION_PER_CONNECTION_OPTION stub
> fixme:wininet:get_proxy_autoconfig_url no support on this platform
> fixme:wininet:query_global_option INTERNET_OPTION_PER_CONNECTION_OPTION stub
> fixme:wininet:get_proxy_autoconfig_url no support on this platform
> fixme:wininet:query_global_option INTERNET_OPTION_PER_CONNECTION_OPTION stub
> internet.c:1387: Test failed: InternetSetOption should've succeeded
>
> Cheers,
> Jacek

Thanks, I'll send the updated version shortly. The failure only occurs under
specific circumstances, and is also fixed with the second patch. I guess I'll
just swap the order, then it should be fine.