Re: [PATCH] programs/cmd: expand commandline before starting parsing it

[Eric Pouech]

Hi Alexandre,

this one will be harder to test... it only happens when cmd is not in batch
mode (ie cmd reading directly from console APIs)
all the tests in cmd/tests are done in batch mode (ie cmd reading from file
APIs)

since the expansion of variables is done currently done differently in
batch mode vs non batch mode in cmd, adding a test to current
infrastructure won't cover the use case
(and it already works correctly in batch mode)

it would require a new test harness inside cmd/tests to generate console
input events instead of just passing the file handle

I'll provide the tests UC for the other patches, but I'm rather in favor of
applying this patch without a test case

A+


On Wed, 5 Jan 2022 at 22:58, Marvin <testbot(a)winehq.org> wrote:
> Thank you for your contribution to Wine!
>
> This is an automated notification to let you know that your patch has
> been reviewed and its status set to "Needs tests".
>
> This means that you need to write some test cases demonstrating that
> the patch is correct.
>
> If you do not understand the reason for this status, disagree with our
> assessment, or are simply not sure how to proceed next, please ask for
> clarification by replying to this email.

-- 
-- 
Eric Pouech

[PATCH] programs/cmd: expand commandline before starting parsing it

[Alexandre Julliard]

Eric Pouech <eric.pouech(a)gmail.com> writes:
> Hi Alexandre,
>
> this one will be harder to test... it only happens when cmd is not in batch mode (ie cmd reading directly from console APIs)
> all the tests in cmd/tests are done in batch mode (ie cmd reading from file APIs)
>
> since the expansion of variables is done currently done differently in batch mode vs non batch mode in cmd, adding a test to current infrastructure won't cover the use case
> (and it already works correctly in batch mode)
>
> it would require a new test harness inside cmd/tests to generate console input events instead of just passing the file handle
>
> I'll provide the tests UC for the other patches, but I'm rather in favor of applying this patch without a test case

All right. But if it's only in interactive mode I assume that it's not
fixing any real application, so it should wait until after code freeze.

-- 
Alexandre Julliard
julliard(a)winehq.org