Re: msxml3/domdoc: Handle passed BSTR argument as a WCHAR string in ::createProcessingInstruction()

[Jacek Caban]

On 10/25/10 10:38 PM, Nikolay Sivov wrote:
> Should help with http://bugs.winehq.org/show_bug.cgi?id=22607

+        V_VT(&v)   = VT_BSTR;
+        V_BSTR(&v) = SysAllocString(data);

-        hr = node_put_value(node_obj,&v_data);

Allocating a string only because it's needed for VariantChangeType (back to the string) seems like a bad design. How about moving xmlNodeSetContent call (and supporting xmlChar_from_wchar) to separated function (node_set_content?) from node_put_value and call it directly here?


Jacek

msxml3/domdoc: Handle passed BSTR argument as a WCHAR string in ::createProcessingInstruction()

[Nikolay Sivov]

On 10/26/2010 01:41, Jacek Caban wrote:
> On 10/25/10 10:38 PM, Nikolay Sivov wrote:
> > Should help with http://bugs.winehq.org/show_bug.cgi?id=22607
>
> +        V_VT(&v)   = VT_BSTR;
> +        V_BSTR(&v) = SysAllocString(data);
>
> -        hr = node_put_value(node_obj,&v_data);
>
> Allocating a string only because it's needed for VariantChangeType (back to the string) seems like a bad design. How about moving xmlNodeSetContent call (and supporting xmlChar_from_wchar) to separated function (node_set_content?) from node_put_value and call it directly here?
> Agreed. New helper could use in some other places too.
>
> Jacek