Owen Rudge : shell32: Implement SHGetImageList and remove todo_wine from imagelist tests.
17 Nov
2009
17 Nov
'09
3:55 p.m.
Hi, Owen. There's a mistake here. + hNew = ImageList_Duplicate(iImageList == SHIL_LARGE ? hLarge : hSmall); + + /* Get the interface for the new image list */ + if (hNew) + { + ret = HIMAGELIST_QueryInterface(hNew, riid, ppv); + + if (!SUCCEEDED(ret)) + ImageList_Destroy(hNew); + } After duplication hNew already has refcount == 1, after HIMAGELIST_QueryInterface is goes to 2, and it isn't what you want. To hide checking riid just remove condition before ImageList_Destroy.
5873
Age (days ago)
5873
Last active (days ago)
0 comments
1 participants
participants (1)
-
Nikolay Sivov