[PATCH] comctrl32: Use clrTextBk color for icon backgrounds when TVS_FULLROWSELECT is used.

[Alistair Leslie-Hughes]

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
---
 dlls/comctl32/treeview.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/comctl32/treeview.c b/dlls/comctl32/treeview.c
index 65eff8b..0980e34 100644
--- a/dlls/comctl32/treeview.c
+++ b/dlls/comctl32/treeview.c
@@ -2640,7 +2640,9 @@ TREEVIEW_DrawItem(const TREEVIEW_INFO *infoPtr, HDC hdc, TREEVIEW_ITEM *item)
 
             ImageList_DrawEx(infoPtr->himlNormal, imageIndex, hdc,
                          item->imageOffset, centery - infoPtr->normalImageHeight / 2,
-                         0, 0, infoPtr->clrBk, item->state & TVIS_CUT ? GETBKCOLOR(infoPtr->clrBk) : CLR_DEFAULT,
+                         0, 0,
+                         TREEVIEW_IsFullRowSelect(infoPtr) ? nmcdhdr.clrTextBk : infoPtr->clrBk,
+                         item->state & TVIS_CUT ? GETBKCOLOR(infoPtr->clrBk) : CLR_DEFAULT,
                          style);
 	}
     }
-- 
1.9.1

[Nikolay Sivov]

Why would it work differently only for this style? Do you have a test 
case that touches clrTextBk with and without this style?

[Alistair Leslie-Hughes]

Hi Nikolay,


On 12/04/18 19:03, Nikolay Sivov wrote:
> Why would it work differently only for this style? Do you have a test
> case that touches clrTextBk with and without this style?

To my knowledge only this style cause the background behind the icon to
change.
My test just toggles the FullRowSelect option, so clrTextBk is always set.
Only when FullRowSelect is enabled, the icon (transparent) background
has the wrong color.

Regards
 Alistair

[Nikolay Sivov]

On 04/12/2018 12:33 PM, Alistair Leslie-Hughes wrote:
> Hi Nikolay,
>
> On 12/04/18 19:03, Nikolay Sivov wrote:
> > Why would it work differently only for this style? Do you have a test
> > case that touches clrTextBk with and without this style?
>
> To my knowledge only this style cause the background behind the icon to
> change.
> My test just toggles the FullRowSelect option, so clrTextBk is always set.
> Only when FullRowSelect is enabled, the icon (transparent) background
> has the wrong color.

Alright, I'd like to see that, can you send the binary to me? Unless 
it's in plain winapi that I can build with mingw.
> Regards
>   Alistair