Re: ws2_32/tests: Test the precedence of parameters while creating a socket in WSASocket()

[Austin English]

On Tue, Jul 30, 2013 at 5:13 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote:
>

You forgot the patch.

-- 
-Austin

ws2_32/tests: Test the precedence of parameters while creating a socket in WSASocket()

[Thomas Faber]

On 2013-07-31 02:48, Bruno Jesus wrote:
> +    ok(!getsockopt(sock, SOL_SOCKET, SO_TYPE, (char *) &socktype, &size), "getsockopt failed with %d\n",
> +       WSAGetLastError());

It's not guaranteed that getsockopt is called before WSAGetLastError
here. (in fact the latter will be evaluated first with most practically
used calling conventions)
So this needs a variable.

Best,
Thomas

ws2_32/tests: Test the precedence of parameters while creating a socket in WSASocket()

[Bruno Jesus]

On Wed, Jul 31, 2013 at 10:21 AM, Thomas Faber <thfabba(a)gmx.de> wrote:
> On 2013-07-31 02:48, Bruno Jesus wrote:
> > +    ok(!getsockopt(sock, SOL_SOCKET, SO_TYPE, (char *) &socktype, &size), "getsockopt failed with %d\n",
> > +       WSAGetLastError());
>
> It's not guaranteed that getsockopt is called before WSAGetLastError
> here. (in fact the latter will be evaluated first with most practically
> used calling conventions)
> So this needs a variable.

I see, thanks. Unfortunately previous patches already introduced that
in 5 other places. If the patch is not commited today I'll change all
older issues and send a new version fixing this. If the patch is
commited today I'll send another patch fixing the 6 places.
> Best,
> Thomas

Best wishes,
Bruno