Re: user32: Allow making window visible by WM_SETREDRAW message.

[Dmitry Timoshkov]

Jacek Caban <jacek(a)codeweavers.com> wrote:
> ---
>  dlls/user32/win.c    | 7 ++-----
>  dlls/user32/win.h    | 1 -
>  dlls/user32/winpos.c | 3 ---
>  3 files changed, 2 insertions(+), 9 deletions(-)

This change needs quite a bit of tests.

-- 
Dmitry.

user32: Allow making window visible by WM_SETREDRAW message.

[Jacek Caban]

Hi Dmitry,

On 03/05/15 15:15, Dmitry Timoshkov wrote:
> Jacek Caban <jacek(a)codeweavers.com> wrote:
> > ---
> >  dlls/user32/win.c    | 7 ++-----
> >  dlls/user32/win.h    | 1 -
> >  dlls/user32/winpos.c | 3 ---
> >  3 files changed, 2 insertions(+), 9 deletions(-)
> > This change needs quite a bit of tests.

We already have tests for that, see test_WM_SETREDRAW. The problem here
is that window has WS_VISIBLE and IsWindowVisible returns TRUE, even
WindowFromPoint reports that the window is present at given position.
However, that does not reflect reality as we don't really show the
window and that's what my patch fixes. If you have a suggestion how to
write a clean test, I'm open for suggestions.

Cheers,
Jacek