Re: ntdll/tests: Remove tests for overlong instructions

[Alexandre Julliard]

"Greg Geldorp" <ggeldorp(a)vmware.com> writes:
> The "overlong instruction" test produces different results on different
> test machines. Since it fails on other machines besides the TestBot VMs I
> don't think this is a TestBot problem.

Do you have evidence that it also fails on real hardware?

-- 
Alexandre Julliard
julliard(a)winehq.org

ntdll/tests: Remove tests for overlong instructions

[Greg Geldorp]

> From: Alexandre Julliard
>
> "Greg Geldorp" writes:
> > The "overlong instruction" test produces different results on different
> > test machines. Since it fails on other machines besides the TestBot VMs I
> > don't think this is a TestBot problem.
>
> Do you have evidence that it also fails on real hardware?

No, I don't, since I'm not sure which test results are generated on real
hardware and which on virtual hardware. I found the following failures on
test.winehq.org:

http://test.winehq.org/data/17e66e06d613026387753f350aa2eaedbcb02ac1/2000_Ne...
http://test.winehq.org/data/17e66e06d613026387753f350aa2eaedbcb02ac1/2000_Wi...
http://test.winehq.org/data/b51f8d48128ff0876341e4f31b4d4e1f31f9dad4/2000_Sw...
http://test.winehq.org/data/5f694ddf4c211c1c167a15541c2654175ce42a62/2000_Wi...
http://test.winehq.org/data/5f694ddf4c211c1c167a15541c2654175ce42a62/2000_Wi...
http://test.winehq.org/data/1c7d349f26c89c9be410978148c64f59c987cf82/2000_aj...
http://test.winehq.org/data/1c7d349f26c89c9be410978148c64f59c987cf82/2000_aj...
http://test.winehq.org/data/17e66e06d613026387753f350aa2eaedbcb02ac1/xp_fg-w...

Perhaps the submitters of those results can let us know whether they're using a VM?

Of course, if you prefer I can also either mark the failing tests as broken, or add
an alternative set of allowable results.

Greg.

ntdll/tests: Remove tests for overlong instructions

[Francois Gouget]

On Mon, 20 Dec 2010, Greg Geldorp wrote:
[...]
> http://test.winehq.org/data/17e66e06d613026387753f350aa2eaedbcb02ac1/xp_fg-w...

This is a virtual machine. From the description field:

   Compaq's English Windows XP SP1; cleaned up and moved to VMware + 
   Creative AudioPCI + VMware Tools.

Yay for the description field<g>.


-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
                           La terre est une bêta...

ntdll/tests: Remove tests for overlong instructions

[André Hentschel]

Am 20.12.2010 13:43, schrieb Francois Gouget:
> On Mon, 20 Dec 2010, Greg Geldorp wrote:
> [...]
> > http://test.winehq.org/data/17e66e06d613026387753f350aa2eaedbcb02ac1/xp_fg-w...
>
> This is a virtual machine. From the description field:
>
> Compaq's English Windows XP SP1; cleaned up and moved to VMware + 
>    Creative AudioPCI + VMware Tools.
>
> Yay for the description field<g>.

We also should consider detecting it in winetest if we are on real hardware or not.
There are much examples out there how to do that and even to detect which kind of VM.
The Question is just if it is worth the work.

-- 

Best Regards, André Hentschel