OOo2.0beta2 installer crashes wine-20050830 in ACTION_VerifyComponentForAction

[Dan Kegel]

Here's a log of wine-20050830 crashing while running the
setup.exe in the directory created by unpacking OOo_2.0beta2_Win32Intel_install.zip.
(This is on FC3, with wine-20050830 compiled from source tarball.)

Is this fixed in CVS, perhaps?

...
fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action L"MoveFiles"
fixme:msi:ACTION_InstallFiles Write DiskPrompt
wine: Unhandled exception (thread 000b), starting debugger...
WineDbg starting on pid 0xa
Unhandled exception: page fault on read access to 0x00000510 in 32-bit code (0x7b800327).
In 32 bit mode.
Register dump:
  CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033
  EIP:7b800327 ESP:7b92f700 EBP:7b92f700 EFLAGS:00010246(   - 00      -RIZP1)
  EAX:00000000 EBX:7b82a720 ECX:00000000 EDX:00000003
  ESI:7b05ef18 EDI:7c228a70
Stack dump:
0x7b92f700:  7b92f748 7b7fc52f 7bcc51d8 00000000
0x7b92f710:  00000003 7b82edc8 7b82edc8 7b82edc8
0x7b92f720:  00000018 7b82edc8 7bcc5204 4d430002
0x7b92f730:  7b05efdc 00000000 7c097368 7b82a720
0x7b92f740:  7b05f000 00000012 7b92f778 7b7e772d
0x7b92f750:  7bcc51d8 004900d0 7b82edc8 00000001
Backtrace:
=>1 0x7b800327 ACTION_VerifyComponentForAction+0xb(package=0x7bcc51d8, comp=0x0, check=0x3) [/home/dank/wine-20050830/dlls/msi/helpers.c:752] in msi (0x7b92f700)
   2 0x7b7fc52f ACTION_InstallFiles(package=0x7bcc51d8) [/home/dank/wine-20050830/dlls/msi/files.c:676] in msi (0x7b92f748)
   3 0x7b7e772d ACTION_HandleStandardAction+0x251(rc=0x7b92f78c, force=0x1) [/home/dank/wine-20050830/dlls/msi/action.c:817] in msi (0x7b92f778)
   4 0x7b7e77fe ACTION_PerformAction+0x3e(package=0x7bcc51d8, action=0x7b05efe8, force=0x1) [/home/dank/wine-20050830/dlls/msi/action.c:866] in msi (0x7b92f79c)
   5 0x7b7e8c35 execute_script [/home/dank/wine-20050830/dlls/msi/action.c:1279] in msi (0x7b92f7cc)
   6 0x7b7ed9bc ACTION_InstallFinalize+0x20(package=0x7bcc51d8) [/home/dank/wine-20050830/dlls/msi/action.c:3599] in msi (0x7b92f7dc)
   7 0x7b7e772d ACTION_HandleStandardAction(rc=0x7b92f820, force=0x0) [/home/dank/wine-20050830/dlls/msi/action.c:817] in msi (0x7b92f80c)
   8 0x7b7e77fe ACTION_PerformAction+0x3e(package=0x7bcc51d8, action=0x7b05f5d0, force=0x0) [/home/dank/wine-20050830/dlls/msi/action.c:866] in msi (0x7b92f830)
   9 0x7b7e7a59 ITERATE_Actions(row=0x7bd2d9b8, param=0x7b92f898) [/home/dank/wine-20050830/dlls/msi/action.c:679] in msi (0x7b92f850)
   10 0x7b806990 MSI_IterateRecords+0x70(view=0x7bd28478, count=0x0, func=0x7b7e7998, param=0x7b92f898) [/home/dank/wine-20050830/dlls/msi/msiquery.c:220] in msi (0x7b92f878)
   11 0x7b7e7486 ACTION_ProcessExecSequence+0xc6 [/home/dank/wine-20050830/dlls/msi/action.c:744] in msi (0x7b92f8ac)
   12 0x7b7ede17 ACTION_ExecuteAction(package=0x7bcc51d8) [/home/dank/wine-20050830/dlls/msi/action.c:3783] in msi (0x7b92f8dc)
   13 0x7b7e772d ACTION_HandleStandardAction(rc=0x7b92f920, force=0x1) [/home/dank/wine-20050830/dlls/msi/action.c:817] in msi (0x7b92f90c)
   14 0x7b7e78e5 ACTION_PerformUIAction+0x3d(package=0x7bcc51d8, action=0x7bd255f8) [/home/dank/wine-20050830/dlls/msi/action.c:887] in msi (0x7b92f930)
   15 0x7b7e79f2 ITERATE_Actions(row=0x7bd243c0, param=0x7b92f9bc) [/home/dank/wine-20050830/dlls/msi/action.c:677] in msi (0x7b92f94c)
   16 0x7b806990 MSI_IterateRecords+0x70(view=0x7bd23a98, count=0x0, func=0x7b7e7998, param=0x7b92f9bc) [/home/dank/wine-20050830/dlls/msi/msiquery.c:220] in msi (0x7b92f974)
   17 0x7b7e8035 ACTION_DoTopLevelINSTALL+0x41d(package=0x7bcc51d8, szPackagePath=0x7bcc496e, szCommandLine=0x0, msiFilePath=0x7b92fa1c) [/home/dank/wine-20050830/dlls/msi/action.c:773] in msi (0x7b92f9f4)
   18 0x7b8043a8 MsiInstallProductW+0x138(szPackagePath=0x7bcc496e, szCommandLine=0x0) [/home/dank/wine-20050830/dlls/msi/msi.c:233] in msi (0x7b92fe48)
   19 0x7b94cbc4 main(argc=0x3, argv=0x7bc604f8) [/home/dank/wine-20050830/programs/msiexec/msiexec.c:298] in msiexec (0x7b92ff10)
   20 0x7b94d785 __wine_spec_exe_entry(peb=0x7beff8c0) [/home/dank/wine-20050830/dlls/winecrt0/exe_entry.c:34] in msiexec (0x7b92ff2c)
   21 0x7bbbf827 start_process+0xc3(arg=0x0) [/home/dank/wine-20050830/dlls/kernel/process.c:995] in kernel32 (0x7b92fff4)
   22 0xf6fde6a1 wine_switch_to_stack+0x11 in libwine.so.1 (0x00000000)
0x7b800327 ACTION_VerifyComponentForAction+0xb [/home/dank/wine-20050830/dlls/msi/helpers.c:752] in msi: cmpl   %edx,0x510(%ecx)
752         if (comp->Installed == check)

-- 
Trying to get a job as a c++ developer?  See http://kegel.com/academy/getting-hired.html

OOo2.0beta2 installer crashes wine-20050830 in ACTION_VerifyComponentForAction

[Mike McCormack]

Dan Kegel wrote:
> Here's a log of wine-20050830 crashing while running the
> setup.exe in the directory created by unpacking 
> OOo_2.0beta2_Win32Intel_install.zip.
> (This is on FC3, with wine-20050830 compiled from source tarball.)
>
> Is this fixed in CVS, perhaps?

No, it's not fixed yet.  This is fallout from my conversion of some of 
the code to use linked lists rather than indexes.  Previously the code 
would access some undefined value at array[-1].

Could you please try the attached patch, and see if it fixes things for you?

Mike


ChangeLog:
* make sure not to access invalid components or features

OOo2.0beta2 installer crashes wine-20050830 in ACTION_VerifyComponentForAction

[Dan Kegel]

Mike McCormack wrote:
> > Here's a log of wine-20050830 crashing while running the
> > setup.exe in the directory created by unpacking 
> > OOo_2.0beta2_Win32Intel_install.zip.
> > (This is on FC3, with wine-20050830 compiled from source tarball.)
> > ...
>
> Could you please try the attached patch, and see if it fixes things for 
> you?

Hey, that got farther, I think.  Thanks!
I'll post about the new problem in a separate message.
- Dan


-- 
Trying to get a job as a c++ developer?  See http://kegel.com/academy/getting-hired.html