On Fri, 16 May 2003, Robert Shearman wrote:
Fixes two bugs. 1. Regression. The colour used for the background of text that wasn't selected wasn't being set properly any more, as it had been moved into notify_prepaint. This patch moves it back to where it was before and the text background appears correctly.
Maxim and I are working on an alternative patch, which also does a better job of handling subitem notifications. Alexandre, please don't apply.
2. Don't clear the item header when column 0 is inserted - it would clear anything already set in the header, such as information set by InsertItem
Well, the header contains the text and the icon. When I insert a new column, I don't expect the old column text to be preserved. Do you have tests that show otherwise? -- Dimi.
hehe you sent your comment just one minute before me :) at least we are in agreement Max On Fri, 2003-05-16 at 19:06, Dimitrie O. Paun wrote:
On Fri, 16 May 2003, Robert Shearman wrote:
Fixes two bugs. 1. Regression. The colour used for the background of text that wasn't selected wasn't being set properly any more, as it had been moved into notify_prepaint. This patch moves it back to where it was before and the text background appears correctly.
Maxim and I are working on an alternative patch, which also does a better job of handling subitem notifications. Alexandre, please don't apply.
2. Don't clear the item header when column 0 is inserted - it would clear anything already set in the header, such as information set by InsertItem
Well, the header contains the text and the icon. When I insert a new column, I don't expect the old column text to be preserved. Do you have tests that show otherwise? -- Maxime Bellengé <maxime.bellenge(a)laposte.net>
-----Original Message----- From: Dimitrie O. Paun [mailto:dimi(a)intelliware.ca] Sent: 16 May 2003 18:07 To: wine-devel(a)winehq.org Cc: Robert Shearman Subject: Re: Fix ListView Bugs On Fri, 16 May 2003, Robert Shearman wrote:
Maxim and I are working on an alternative patch, which also does a better job of handling subitem notifications. Alexandre, please don't apply.
Excellent!
2. Don't clear the item header when column 0 is inserted - it would clear anything already set in the header, such as information set by InsertItem
Well, the header contains the text and the icon. When I insert a new column, I don't expect the old column text to be preserved. Do you have tests that show otherwise?
Yes, I have attached code (unfortunately developed on VC++) and executable. Also, inetcpl.cpl depends on this feature. Rob
On Fri, 16 May 2003, Robert Shearman wrote:
Yes, I have attached code (unfortunately developed on VC++) and executable. Also, inetcpl.cpl depends on this feature.
Unfortunately, I don't have a way to compile it. Can you also email me an executable? Also, a short description of the desired behaviour (vs. current one) would be nice. -- Dimi.
-----Original Message----- From: Dimitrie O. Paun [mailto:dimi(a)intelliware.ca] Sent: 16 May 2003 18:35 To: Robert Shearman Cc: wine-devel(a)winehq.com Subject: RE: Fix ListView Bugs On Fri, 16 May 2003, Robert Shearman wrote:
Yes, I have attached code (unfortunately developed on VC++) and executable. Also, inetcpl.cpl depends on this feature.
Unfortunately, I don't have a way to compile it. Can you also email me an executable? Also, a short description of the desired behaviour (vs. current one) would be nice.
There should be an executable (PE format) attached with the email (if not it is available at http://www.winehq.org/hypermail/wine-devel/2003/05/att-0457/01-ListViewTest. exe). Using the native comctl32, it should appear correctly with a different icon. Using builtin comctl32 it would display no text for both the items and both would use the same icon. Rob
On Fri, 16 May 2003, Robert Shearman wrote:
Using the native comctl32, it should appear correctly with a different icon. Using builtin comctl32 it would display no text for both the items and both would use the same icon.
I can't test your app with Wine right now, but I think I see what's going on. However, I don't think your patch is right. Can you please also check what the behaviour is in LVS_REPORT mode? -- insert a few items in a LVS_REPORT listview with 3 columns -- insert a new column 0 What do you get? -- Dimi.
-----Original Message----- From: Dimitrie O. Paun [mailto:dimi(a)intelliware.ca] Sent: 16 May 2003 20:44 To: Robert Shearman Cc: wine-devel(a)winehq.com Subject: RE: Fix ListView Bugs
Can you please also check what the behaviour is in LVS_REPORT mode? -- insert a few items in a LVS_REPORT listview with 3 columns -- insert a new column 0 What do you get?
Right, I start off with 3 columns, Testing, Testing2 and Testing3 in that order. I now insert a column Testing4 at position 0 and both the icon and text are present as before, now listed under the Testing4 column (followed by the blank columns Testing, Testing2 and Testing3). Rob
On Fri, 16 May 2003, Robert Shearman wrote:
Right, I start off with 3 columns, Testing, Testing2 and Testing3 in that order. I now insert a column Testing4 at position 0 and both the icon and text are present as before, now listed under the Testing4 column (followed by the blank columns Testing, Testing2 and Testing3).
Cool. Can you please also insert an item into the list _before_ you insert Testing4 at position 0 (with values Value1, Value2, and Value3), to see what happens to the rest of the subitems on the column insertion. -- Dimi.
-----Original Message----- From: Dimitrie O. Paun [mailto:dimi(a)intelliware.ca] Sent: 16 May 2003 22:42 To: Robert Shearman Cc: wine-devel(a)winehq.com Subject: RE: Fix ListView Bugs
Cool. Can you please also insert an item into the list _before_ you insert Testing4 at position 0 (with values Value1, Value2, and Value3), to see what happens to the rest of the subitems on the column insertion.
The subitems are shifted along by one if a column is inserted before that subitem's column, otherwise the items stay the same. Rob
On May 16, 2003 06:48 pm, Robert Shearman wrote:
The subitems are shifted along by one if a column is inserted before that subitem's column, otherwise the items stay the same.
So, if I understand you correctly, if I insert a new column at position i, then all items from [0..i] stay put, i+1 becomes the new (empty column), and all items that were before at postion [i+1, ..] get shifted to postion [i+2, ...] Somehow this doesn't seem right: why do I get the new column at i+1 if I inserted at i? I think I'm off by one... -- Dimi.
-----Original Message----- From: Dimitrie O. Paun [mailto:dpaun(a)rogers.com] Sent: 17 May 2003 00:10 To: Robert Shearman Cc: wine-devel(a)winehq.com Subject: Re: Fix ListView Bugs
So, if I understand you correctly, if I insert a new column at position i, then all items from [0..i] stay put, i+1 becomes the new (empty column), and all items that were before at postion [i+1, ..] get shifted to postion [i+2, ...]
No, the inserted column becomes the empty one. Sorry, I should have made this a bit clearer.
Somehow this doesn't seem right: why do I get the new column at i+1 if I inserted at i? I think I'm off by one...
The new column becomes the i'th column. E.g. (inserting at column 2): 0 | 1 | 2 | 3 X X X X 0 | 1 | 2 | 3 | 4 X X X X 0->0, 1->1, 2->3, 3->4 Hope this makes things clearer, Rob
On May 16, 2003 07:28 pm, Robert Shearman wrote:
The new column becomes the i'th column. E.g. (inserting at column 2):
0 | 1 | 2 | 3 X X X X
0 | 1 | 2 | 3 | 4 X X X X
0->0, 1->1, 2->3, 3->4
Hope this makes things clearer,
Yes, it does, but now what happens when you insert at 0? This: 0 | 1 | 2 | 3 | 4 X X X X or this: 0 | 1 | 2 | 3 | 4 X X X X If it's the first thing (which is what I'd expect), the current code does just that, no? -- Dimi.
participants (4)
-
Dimitrie O. Paun -
Dimitrie O. Paun -
Maxime Bellengé -
Robert Shearman