Re: [PATCH 1/2] user32: Fix return value of EDIT_EM_Scroll. (try 2)
David Hedberg <david.hedberg(a)gmail.com> writes:
Brings the return value in line with msdn and test results.
This time without the skips. Return values other than 0 are somewhat unlikely, but strictly speaking only one value is wrong (and important for the tests here).
I wouldn't expect it to ever return something other than 0 here, but even if it does there are many other possible wrong values. It's better to make the test as strict as you can to catch more potential problems, rather than limiting yourself to the specific value that you encountered. -- Alexandre Julliard julliard(a)winehq.org
On Wed, Mar 3, 2010 at 12:53 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
David Hedberg <david.hedberg(a)gmail.com> writes:
Brings the return value in line with msdn and test results.
This time without the skips. Return values other than 0 are somewhat unlikely, but strictly speaking only one value is wrong (and important for the tests here).
I wouldn't expect it to ever return something other than 0 here, but even if it does there are many other possible wrong values. It's better to make the test as strict as you can to catch more potential problems, rather than limiting yourself to the specific value that you encountered.
Understood, I'll fix that and send again.
-- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alexandre Julliard -
David Hedberg