Re: [PATCH] winex11: Avoid double initialization of variables in OpenGL functions.

[Matteo Bruni]

2015-11-04 20:52 GMT+01:00 Alex Henrie <alexhenrie24(a)gmail.com>:
> 2015-11-04 12:22 GMT-07:00 Vincent Povirk <vincent(a)codeweavers.com>:
> > Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com>
> >
> > Although I don't see anything wrong with 'get_render_type_from_fbconfig' as-is.
>
> I moved the render_type = 0 assignment into a conditional branch. If
> there was not a default case in that function already, it would not
> have made a difference, because a jump instruction takes the same
> amount of time or more as zeroing out a variable. But since we already
> have the conditional, it makes more sense to move the initialization
> into that conditional branch to avoid the cost of initializing the
> variable unnecessarily.

I doubt that actually modifies the generated code, although that's
probably true for all the changes in this patch. The other changes at
least simplify the code a bit.

Anyway, the patch is okay with me FWIW.