Re: wbemprox: Add a Win32_LogicalDisk class stub.

[Hans Leidekker]

On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote:
> +static void fill_logicaldisk( struct table *table )
> +{
> +    static const WCHAR caption[] =
> +        {'C',':',0};
> +    static const WCHAR description[] =
> +        {'L','o','c','a','l',' ','F','i','x','e','d',' ','D','i','s','k',0};
> +    static const WCHAR device_id[] =
> +        {'C',':',0};
> +    struct record_logicaldisk *rec;
> +    FIXME("returns a fake logical disks table\n");
> +    if (!(table->data = heap_alloc( sizeof(*rec) )))
> +    {
> +        return;
> +    }
> +    rec = (struct record_logicaldisk *)(table->data);
> +    rec->caption        = caption;
> +    rec->description    = description;
> +    rec->device_id      = device_id;
> +    table->num_rows = 1;
> +    TRACE("created %u row(s)\n", table->num_rows);

That's better. Does NFS actually query the Caption and Description properties?

wbemprox: Add a Win32_LogicalDisk class stub.

[John Yani]

On 28 June 2012 22:17, Hans Leidekker <hans(a)codeweavers.com> wrote:
> On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote:
> > +static void fill_logicaldisk( struct table *table )
> > +{
> > +    static const WCHAR caption[] =
> > +        {'C',':',0};
> > +    static const WCHAR description[] =
> > +        {'L','o','c','a','l',' ','F','i','x','e','d',' ','D','i','s','k',0};
> > +    static const WCHAR device_id[] =
> > +        {'C',':',0};
> > +    struct record_logicaldisk *rec;
> > +    FIXME("returns a fake logical disks table\n");
> > +    if (!(table->data = heap_alloc( sizeof(*rec) )))
> > +    {
> > +        return;
> > +    }
> > +    rec = (struct record_logicaldisk *)(table->data);
> > +    rec->caption        = caption;
> > +    rec->description    = description;
> > +    rec->device_id      = device_id;
> > +    table->num_rows = 1;
> > +    TRACE("created %u row(s)\n", table->num_rows);
>
> That's better. Does NFS actually query the Caption and Description properties?

Well, no. I just thought the output should be similar to the one on
winetestbot: https://testbot.winehq.org/JobDetails.pl?Key=19642&log_201=1#k201

wbemprox: Add a Win32_LogicalDisk class stub.

[Hans Leidekker]

On Thu, 2012-06-28 at 22:22 +0300, John Yani wrote:
> On 28 June 2012 22:17, Hans Leidekker <hans(a)codeweavers.com> wrote:
> > On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote:
> > That's better. Does NFS actually query the Caption and Description properties?
>
> Well, no. I just thought the output should be similar to the one on
> winetestbot: https://testbot.winehq.org/JobDetails.pl?Key=19642&log_201=1#k201

No, that's just a test I wrote to investigate this stuff.

wbemprox: Add a Win32_LogicalDisk class stub.

[John Yani]

So, is this patch good?

wbemprox: Add a Win32_LogicalDisk class stub.

[John Yani]

NFS requests "Size" and "FreeSpace" fields. Not sure if  it require
them to be set.