Re: [PATCH] const variables are not compile-time constants

[Octavian Voicu]

On Sun, Jul 25, 2010 at 11:36 PM, Mikko Rasa <tdb(a)tdb.fi> wrote:
> -    static const DWORD user_flags = clip_flags | DCX_NORESETATTRS; /* flags that can be set by user */
> +    static const DWORD user_flags = DCX_PARENTCLIP | DCX_CLIPSIBLINGS | DCX_CLIPCHILDREN | DCX_WINDOW
> +        | DCX_NORESETATTRS; /* flags that can be set by user */

This should be committed first thing tomorrow imho (in order to
minimize the number of potential compile errors in case of a bisect).

Octavian

[PATCH] const variables are not compile-time constants

[Alexandre Julliard]

Octavian Voicu <octavian.voicu(a)gmail.com> writes:
> On Sun, Jul 25, 2010 at 11:36 PM, Mikko Rasa <tdb(a)tdb.fi> wrote:
> > -    static const DWORD user_flags = clip_flags | DCX_NORESETATTRS; /* flags that can be set by user */
> > +    static const DWORD user_flags = DCX_PARENTCLIP | DCX_CLIPSIBLINGS | DCX_CLIPCHILDREN | DCX_WINDOW
> > +        | DCX_NORESETATTRS; /* flags that can be set by user */
>
> This should be committed first thing tomorrow imho (in order to
> minimize the number of potential compile errors in case of a bisect).

Doing a bisect with custom compile flags is not a good idea. That sort
of thing happens from time to time.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH] const variables are not compile-time constants

[Henri Verbeet]

On 26 July 2010 10:00, Alexandre Julliard <julliard(a)winehq.org> wrote:
> Octavian Voicu <octavian.voicu(a)gmail.com> writes:
> > On Sun, Jul 25, 2010 at 11:36 PM, Mikko Rasa <tdb(a)tdb.fi> wrote:
> > > -    static const DWORD user_flags = clip_flags | DCX_NORESETATTRS; /* flags that can be set by user */
> > > +    static const DWORD user_flags = DCX_PARENTCLIP | DCX_CLIPSIBLINGS | DCX_CLIPCHILDREN | DCX_WINDOW
> > > +        | DCX_NORESETATTRS; /* flags that can be set by user */
> >
> > This should be committed first thing tomorrow imho (in order to
> > minimize the number of potential compile errors in case of a bisect).
>
> Doing a bisect with custom compile flags is not a good idea. That sort
> of thing happens from time to time.

It fails for me with gcc 4.4.4 on Debian squeeze, without particularly
special compile flags. Maybe it's a Debian thing, but you don't have
to try very hard to run into this.

[PATCH] const variables are not compile-time constants

[Michael Stefaniuc]

Henri Verbeet wrote:
> On 26 July 2010 10:00, Alexandre Julliard <julliard(a)winehq.org> wrote:
> > Octavian Voicu <octavian.voicu(a)gmail.com> writes:
> > > On Sun, Jul 25, 2010 at 11:36 PM, Mikko Rasa <tdb(a)tdb.fi> wrote:
> > > > -    static const DWORD user_flags = clip_flags | DCX_NORESETATTRS; /* flags that can be set by user */
> > > > +    static const DWORD user_flags = DCX_PARENTCLIP | DCX_CLIPSIBLINGS | DCX_CLIPCHILDREN | DCX_WINDOW
> > > > +        | DCX_NORESETATTRS; /* flags that can be set by user */
> > > > This should be committed first thing tomorrow imho (in order to
> > > > minimize the number of potential compile errors in case of a bisect).
> > > > Doing a bisect with custom compile flags is not a good idea. That sort
> > > > of thing happens from time to time.
>
> It fails for me with gcc 4.4.4 on Debian squeeze, without particularly
> special compile flags. Maybe it's a Debian thing, but you don't have
> to try very hard to run into this.
> Works for me with the gcc 4.4.4 on F13 but it breaks with the old 3.1.1
> gcc used by the old Smatch.

bye
	michael

[PATCH] const variables are not compile-time constants

[Henri Verbeet]

On 26 July 2010 17:08, Michael Stefaniuc <mstefani(a)redhat.com> wrote:
> Works for me with the gcc 4.4.4 on F13 but it breaks with the old 3.1.1
> gcc used by the old Smatch.

Well, it works with 4.4.3 on Gentoo for me as well... :-) just saying
that you don't necessarily have to try very hard to break it.